* bug#30515: 26.0; `mouse-1' in Profiler report
[not found] <80cbb241-0c6c-45ea-98a9-8b145af1fab5@default>
@ 2019-07-14 16:21 ` Lars Ingebrigtsen
2019-07-25 20:01 ` Lars Ingebrigtsen
0 siblings, 1 reply; 2+ messages in thread
From: Lars Ingebrigtsen @ 2019-07-14 16:21 UTC (permalink / raw)
To: Drew Adams; +Cc: 30515
Drew Adams <drew.adams@oracle.com> writes:
> In the output of `profiler-report', `mouse-1' does not respect option
> `mouse-1-click-follows-link'.
The patch below seems to fix this (and works with
mouse-1-click-follows-link both nil or not.
But is this really the way to do this stuff these days? It seems so...
odd...
diff --git a/lisp/profiler.el b/lisp/profiler.el
index 775096276d..ee11ff68c5 100644
--- a/lisp/profiler.el
+++ b/lisp/profiler.el
@@ -473,6 +473,7 @@ profiler-report-make-entry-part
(fboundp entry))
(propertize (symbol-name entry)
'face 'link
+ 'follow-link "\r"
'mouse-face 'highlight
'help-echo "\
mouse-2: jump to definition\n\
@@ -534,9 +535,9 @@ profiler-report-mode-map
(define-key map "\r" 'profiler-report-toggle-entry)
(define-key map "\t" 'profiler-report-toggle-entry)
(define-key map "i" 'profiler-report-toggle-entry)
- (define-key map [mouse-1] 'profiler-report-toggle-entry)
(define-key map "f" 'profiler-report-find-entry)
(define-key map "j" 'profiler-report-find-entry)
+ (define-key map [follow-link] 'mouse-face)
(define-key map [mouse-2] 'profiler-report-find-entry)
(define-key map "d" 'profiler-report-describe-entry)
(define-key map "C" 'profiler-report-render-calltree)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#30515: 26.0; `mouse-1' in Profiler report
2019-07-14 16:21 ` bug#30515: 26.0; `mouse-1' in Profiler report Lars Ingebrigtsen
@ 2019-07-25 20:01 ` Lars Ingebrigtsen
0 siblings, 0 replies; 2+ messages in thread
From: Lars Ingebrigtsen @ 2019-07-25 20:01 UTC (permalink / raw)
To: Drew Adams; +Cc: 30515
I've now applied the patch.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-25 20:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <80cbb241-0c6c-45ea-98a9-8b145af1fab5@default>
2019-07-14 16:21 ` bug#30515: 26.0; `mouse-1' in Profiler report Lars Ingebrigtsen
2019-07-25 20:01 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).