bug#29663: 26.0.90; autho-source-pass-entries hardcodes .password-store directory

bug#29663: 26.0.90; autho-source-pass-entries hardcodes .password-store directory

[John Wiegley]

`auth-source-pass-entries' is defined as follows:

  (defun auth-source-pass-entries ()
    "Return a list of all password store entries."
    (let ((store-dir (expand-file-name "~/.password-store/")))
      (mapcar
       (lambda (file) (file-name-sans-extension (file-relative-name file store-dir)))
       (directory-files-recursively store-dir "\.gpg$"))))

However, the pass utility does not require that this be the directory where
passwords are stored. This should be a customizable variable, initialized from
the value of (getenv "PASSWORD_STORE_DIR") if set.

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

bug#29663: Acknowledgement (26.0.90; autho-source-pass-entries hardcodes .password-store directory)

[John Wiegley]

Note that the same problem occurs here too:

  (defun auth-source-pass--read-entry (entry)
    "Return a string with the file content of ENTRY."
    (with-temp-buffer
      (insert-file-contents (expand-file-name
                             (format "%s.gpg" entry)
                             "~/.password-store"))
      (buffer-substring-no-properties (point-min) (point-max))))

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

bug#29663: 26.0.90; autho-source-pass-entries hardcodes .password-store directory

[Stefan Kangas]

[-- Attachment #1: Type: text/plain, Size: 958 bytes --]

"John Wiegley" <johnw@gnu.org> writes:

> `auth-source-pass-entries' is defined as follows:
>
>   (defun auth-source-pass-entries ()
>     "Return a list of all password store entries."
>     (let ((store-dir (expand-file-name "~/.password-store/")))
>       (mapcar
>        (lambda (file) (file-name-sans-extension (file-relative-name file store-dir)))
>        (directory-files-recursively store-dir "\.gpg$"))))
>
> However, the pass utility does not require that this be the directory where
> passwords are stored. This should be a customizable variable, initialized from
> the value of (getenv "PASSWORD_STORE_DIR") if set.

Hi John,

I see that an option was added recently which takes care of the first
part of your requesti:

a63cbb56df 2019-01-13 Add auth-source-pass-filename option

I've attached a patch which initializes auth-source-pass-filename to
(getenv "PASSWORD_STORE_DIR") when it's set.  What do you think?

Best regards,
Stefan Kangas

[-- Attachment #2: 0001-Use-PASSWORD_STORE_DIR-in-auth-source-pass-when-set.patch --]
[-- Type: text/x-patch, Size: 936 bytes --]

From 2bb16aaa577fe45f7ed18cb84413c53a4c0daea2 Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefankangas@gmail.com>
Date: Sun, 6 Oct 2019 04:02:27 +0200
Subject: [PATCH] Use PASSWORD_STORE_DIR in auth-source-pass when set

* lisp/auth-source-pass.el (auth-source-pass-filename): Initialize to
PASSWORD_STORE_DIR environment variable when set.  (Bug#29663)
---
 lisp/auth-source-pass.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/auth-source-pass.el b/lisp/auth-source-pass.el
index c45c782c27..524a72792c 100644
--- a/lisp/auth-source-pass.el
+++ b/lisp/auth-source-pass.el
@@ -45,7 +45,8 @@ auth-source-pass
   :group 'auth-source
   :version "27.1")
 
-(defcustom auth-source-pass-filename "~/.password-store"
+(defcustom auth-source-pass-filename
+  (or (getenv "PASSWORD_STORE_DIR") "~/.password-store")
   "Filename of the password-store folder."
   :type 'directory
   :version "27.1")
-- 
2.20.1

bug#29663: 26.0.90; autho-source-pass-entries hardcodes .password-store directory

[Basil L. Contovounesios]

Stefan Kangas <stefan@marxist.se> writes:

> I've attached a patch which initializes auth-source-pass-filename to
> (getenv "PASSWORD_STORE_DIR") when it's set.  What do you think?

LGTM, FWIW.

Thanks,

-- 
Basil

bug#29663: 26.0.90; autho-source-pass-entries hardcodes .password-store directory

[Stefan Kangas]

close 29663 27.1
thanks

"Basil L. Contovounesios" <contovob@tcd.ie> writes:

> Stefan Kangas <stefan@marxist.se> writes:
>
>> I've attached a patch which initializes auth-source-pass-filename to
>> (getenv "PASSWORD_STORE_DIR") when it's set.  What do you think?
>
> LGTM, FWIW.

No other comments within 3 weeks, so I've now pushed this as commit
6b2745fe2e.  I'm consequently closing this bug.

Best regards,
Stefan Kangas