unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Alexander Shukaev <emacs@Alexander.Shukaev.name>
Cc: 25188@debbugs.gnu.org
Subject: bug#25188: Initialization of `global-edebug-map' is not safe
Date: Wed, 09 Oct 2019 09:27:50 +0200	[thread overview]
Message-ID: <877e5eqsy1.fsf@gnus.org> (raw)
In-Reply-To: <4f637d8d-29c0-d6cb-6e7e-824bdb173601@Alexander.Shukaev.name> (Alexander Shukaev's message of "Tue, 13 Dec 2016 00:45:07 +0100")

Alexander Shukaev <emacs@Alexander.Shukaev.name> writes:

> (global-unset-key global-edebug-prefix)
> (global-set-key global-edebug-prefix global-edebug-map)
>
> and imagine that somebody has customized `global-map' in such a way
> that it has no "\C-x" prefix command at all.  Then of course the above
> code will fail.  Furthermore, if one does not want to pollute the 
> `global-map' with `global-edebug-map', one cannot simply set
> `global-edebug-prefix' to nil because this would also fail.  I believe 
> `global-edebug-map' should support the nil value which would mean that
> the above code is disabled completely.

I've now made it check whether global-edebug-prefix is nil before using
in Emacs 27.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





      reply	other threads:[~2019-10-09  7:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-12 23:45 bug#25188: Initialization of `global-edebug-map' is not safe Alexander Shukaev
2019-10-09  7:27 ` Lars Ingebrigtsen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877e5eqsy1.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=25188@debbugs.gnu.org \
    --cc=emacs@Alexander.Shukaev.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).