From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#25188: Initialization of `global-edebug-map' is not safe Date: Wed, 09 Oct 2019 09:27:50 +0200 Message-ID: <877e5eqsy1.fsf@gnus.org> References: <4f637d8d-29c0-d6cb-6e7e-824bdb173601@Alexander.Shukaev.name> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="178328"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 25188@debbugs.gnu.org To: Alexander Shukaev Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 09 18:52:42 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iIFCb-000kER-U6 for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Oct 2019 18:52:42 +0200 Original-Received: from localhost ([::1]:52574 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIFCa-0000mo-AX for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Oct 2019 12:52:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39912) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iI6OB-0000nY-5s for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 03:28:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iI6OA-0001Kx-2I for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 03:28:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43186) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iI6O9-0001Kd-VP for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 03:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iI6O9-0007SS-RJ for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 03:28:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Oct 2019 07:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25188 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: easy Original-Received: via spool by 25188-submit@debbugs.gnu.org id=B25188.157060607628649 (code B ref 25188); Wed, 09 Oct 2019 07:28:01 +0000 Original-Received: (at 25188) by debbugs.gnu.org; 9 Oct 2019 07:27:56 +0000 Original-Received: from localhost ([127.0.0.1]:52006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iI6O3-0007S1-Ss for submit@debbugs.gnu.org; Wed, 09 Oct 2019 03:27:56 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:56142) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iI6O1-0007Rr-Qo for 25188@debbugs.gnu.org; Wed, 09 Oct 2019 03:27:54 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iI6Ny-0004Pe-I4; Wed, 09 Oct 2019 09:27:52 +0200 In-Reply-To: <4f637d8d-29c0-d6cb-6e7e-824bdb173601@Alexander.Shukaev.name> (Alexander Shukaev's message of "Tue, 13 Dec 2016 00:45:07 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168716 Archived-At: Alexander Shukaev writes: > (global-unset-key global-edebug-prefix) > (global-set-key global-edebug-prefix global-edebug-map) > > and imagine that somebody has customized `global-map' in such a way > that it has no "\C-x" prefix command at all. Then of course the above > code will fail. Furthermore, if one does not want to pollute the > `global-map' with `global-edebug-map', one cannot simply set > `global-edebug-prefix' to nil because this would also fail. I believe > `global-edebug-map' should support the nil value which would mean that > the above code is disabled completely. I've now made it check whether global-edebug-prefix is nil before using in Emacs 27. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no