bug#46731: Clicking on filename in *Help* now just leaves us at the top of the file

bug#46731: Clicking on filename in *Help* now just leaves us at the top of the file

[積丹尼 Dan Jacobson]

In the *Help* buffer we see:

    gnus-article-treat-non-ascii is an interactive Lisp function in
    ‘gnus-art.el’.

    (gnus-article-treat-non-ascii &optional INTERACTIVE &rest ARGS)

    Translate many Unicode characters into their ASCII equivalents.

OK, we press RETURN on that glowing filename, and instead of whisking us
to the location of the function in that file, we are simply dropped off
at the beginning of the file, "and then our taxi speeds away, leaving
us to hunt for the address ourselves."

bug#46731: Clicking on filename in *Help* now just leaves us at the top of the file

[Lars Ingebrigtsen]

積丹尼 Dan Jacobson <jidanni@jidanni.org> writes:

> In the *Help* buffer we see:
>
>     gnus-article-treat-non-ascii is an interactive Lisp function in
>     ‘gnus-art.el’.
>
>     (gnus-article-treat-non-ascii &optional INTERACTIVE &rest ARGS)
>
>     Translate many Unicode characters into their ASCII equivalents.
>
> OK, we press RETURN on that glowing filename, and instead of whisking us
> to the location of the function in that file, we are simply dropped off
> at the beginning of the file, "and then our taxi speeds away, leaving
> us to hunt for the address ourselves."

Works for me in Emacs 28.  Closing.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#46731: Clicking on filename in *Help* now just leaves us at the top of the file

[Stephen Berman]

On Wed, 24 Feb 2021 17:33:23 +0100 Lars Ingebrigtsen <larsi@gnus.org> wrote:

> 積丹尼 Dan Jacobson <jidanni@jidanni.org> writes:
>
>> In the *Help* buffer we see:
>>
>>     gnus-article-treat-non-ascii is an interactive Lisp function in
>>     `gnus-art.el'.
>>
>>     (gnus-article-treat-non-ascii &optional INTERACTIVE &rest ARGS)
>>
>>     Translate many Unicode characters into their ASCII equivalents.
>>
>> OK, we press RETURN on that glowing filename, and instead of whisking us
>> to the location of the function in that file, we are simply dropped off
>> at the beginning of the file, "and then our taxi speeds away, leaving
>> us to hunt for the address ourselves."
>
> Works for me in Emacs 28.  Closing.

Does it really work for you?  Grepping the lisp/gnus directory for
gnus-article-treat-non-ascii finds only these:

./gnus-sum.el:2218:  "U" gnus-article-treat-non-ascii
./gnus-sum.el:2543:	      ["Non-ASCII" gnus-article-treat-non-ascii t]

There is a defun article-treat-non-ascii and `C-h f
article-treat-non-ascii' contains a link to that, but `C-h f
gnus-article-treat-non-ascii' does not.  I guess that's because of this:

(eval-and-compile
  (mapc
   (lambda (func)
     (let (afunc gfunc)
       (if (consp func)
	   (setq afunc (car func)
		 gfunc (cdr func))
	 (setq afunc func
	       gfunc (intern (format "gnus-%s" func))))
       (defalias gfunc
	 (when (fboundp afunc)
	   `(lambda (&optional interactive &rest args)
	      ,(documentation afunc t)
	      (interactive (list t))
	      (with-current-buffer gnus-article-buffer
		(if interactive
		    (call-interactively ',afunc)
		  (apply #',afunc args))))))))
   '(article-hide-headers
     [...]
     article-treat-non-ascii
     article-normalize-headers)))

Or has there been a recent change that makes the link in the *Help*
buffer displayed by `C-h f gnus-article-treat-non-ascii' actually go to
the defun of article-treat-non-ascii?

Steve Berman

bug#46731: Clicking on filename in *Help* now just leaves us at the top of the file

[Lars Ingebrigtsen]

Stephen Berman <stephen.berman@gmx.net> writes:

> Or has there been a recent change that makes the link in the *Help*
> buffer displayed by `C-h f gnus-article-treat-non-ascii' actually go to
> the defun of article-treat-non-ascii?

Hitting the link in Emacs 28 takes me to the place where the function is
defined, which is the mapc thing.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#46731: Clicking on filename in *Help* now just leaves us at the top of the file

[Stephen Berman]

On Wed, 24 Feb 2021 22:04:10 +0100 Lars Ingebrigtsen <larsi@gnus.org> wrote:

> Stephen Berman <stephen.berman@gmx.net> writes:
>
>> Or has there been a recent change that makes the link in the *Help*
>> buffer displayed by `C-h f gnus-article-treat-non-ascii' actually go to
>> the defun of article-treat-non-ascii?
>
> Hitting the link in Emacs 28 takes me to the place where the function is
> defined, which is the mapc thing.

That doesn't happen in my January 29 build.  I guess it's high time I
update my Emacs master branch!

Steve Berman