bug#49799: 28.0.50; u bound to wrong function in gnus-browse-mode-map

bug#49799: 28.0.50; u bound to wrong function in gnus-browse-mode-map

[Peder O. Klingenberg]

[-- Attachment #1: Type: text/plain, Size: 8585 bytes --]



A recent commit to gnus-srvr.el renamed two functions, one interactive,
the other not.  u was previously bound to the interactive function, but
after the renaming, it's bound to the non-interactive one.  This doesn't
work so well.

Attached is a patch.



In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0, Xaw3d scroll bars)
 of 2021-07-30 built on PedersHP
Repository revision: 0bd1346318fe9ef4eba91905172d30a030d7da18
Repository branch: master
Windowing system distributor 'HC-Consult', version 11.0.12009000
System Description: Ubuntu 20.04.2 LTS

Configured using:
 'configure --with-x-toolkit=lucid --prefix=/usr/local/emacs-git'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS
X11 XAW3D XDBE XIM XPM LUCID ZLIB

Important settings:
  value of $LANG: C.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Group

Minor modes in effect:
  gnus-topic-mode: t
  gnus-undo-mode: t
  recentf-mode: t
  counsel-projectile-mode: t
  ivy-mode: t
  sly-symbol-completion-mode: t
  pyvenv-mode: t
  projectile-mode: t
  global-company-mode: t
  company-mode: t
  beacon-mode: t
  global-git-gutter-mode: t
  global-git-commit-mode: t
  magit-auto-revert-mode: t
  override-global-mode: t
  shell-dirtrack-mode: t
  show-paren-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  column-number-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t

Load-path shadows:
/home/pok/.emacs.d/elpa/transient-20210723.1601/transient hides /usr/local/emacs-git/share/emacs/28.0.50/lisp/transient

Features:
(shadow sort bbdb-message footnote ecomplete mail-extr emacsbug qp
whitespace log-view vc-annotate pulse jka-compr cl-print mule-util
magit-extras ssh-agency dired-aux gnus-ml shortdoc deuglify gnus-async
gnus-cite gnus-cus gnus-demon gnus-diary nndiary gnus-draft gnus-dup
gnus-fun gnus-html url-queue url-cache mm-url gnus-kill gnus-logic
gnus-mh mh-comp mh-scan mh-gnus mh-e mh-compat mh-buffers mh-loaddefs
gnus-registry registry eieio-base gnus-salt gnus-uu yenc gnus-vm
sendmail nnselect gnus-search eieio-opt speedbar ezimage dframe utf-7
epa-file nnfolder gnus-topic nndraft nnmh bbdb-gnus network-stream
gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-msg nntp
gnus-cache bbdb-mua bbdb-vcard bbdb-com bbdb-vcard-vcard21 bbdb
bbdb-site timezone gnus-icalendar org-capture org-refile gnus-art mm-uu
mml2015 mm-view mml-smime smime dig gnus-sum shr kinsoku svg dom
gnus-group gnus-undo gnus-start gnus-dbus dbus gnus-cloud nnimap nnmail
mail-source utf7 netrc nnoo gnus-spec gnus-int gnus-range gnus-win
icalendar diary-lib diary-loaddefs gnus nnheader bat-mode recentf
tree-widget magit-bookmark bookmark ffap counsel-projectile counsel xdg
swiper ivy delsel ivy-faces ivy-overlay colir omnisharp
omnisharp-unit-test-actions omnisharp-code-structure
omnisharp-server-installation omnisharp-format-actions
omnisharp-solution-actions omnisharp-helm-integration
omnisharp-navigation-actions omnisharp-current-symbol-actions
omnisharp-auto-complete-actions omnisharp-server-actions
omnisharp-http-utils omnisharp-utils omnisharp-server-management
omnisharp-settings f flycheck popup csharp-mode csharp-compilation
cc-langs smartparens-c cc-mode cc-fonts cc-guess cc-menus cc-cmds
cc-styles cc-align cc-engine cc-vars cc-defs cl display-line-numbers
smartparens-config smartparens-org smartparens-python
smartparens-markdown smartparens-text smartparens wheatgrass-theme
multi-vterm vterm face-remap term disp-table ehelp vterm-module
term/xterm xterm restclient sly sly-completion sly-buttons sly-messages
sly-common apropos arc-mode archive-mode hyperspec gradle-mode
groovy-mode debbugs soap-client rng-xsd rng-dt rng-util xsd-regexp xml
virtualenvwrapper gud highlight-indentation flymake-proc flymake
warnings help-fns radix-tree elpy elpy-rpc pyvenv eshell esh-cmd esh-ext
esh-opt esh-proc esh-io esh-arg esh-module esh-groups esh-util
elpy-shell elpy-profile elpy-django s elpy-refactor ido company-jedi
jedi-core python-environment epc ctable concurrent deferred projectile
markdown-preview-eww yasnippet company-oddmuse company-keywords
company-etags etags fileloop generator xref project company-gtags
company-dabbrev-code company-dabbrev company-files company-clang
company-capf company-cmake company-semantic company-template
company-bbdb company pcase use-package-diminish easy-kill rg vc
rg-info-hack rg-menu rg-ibuffer rg-result wgrep-rg wgrep rg-history
rg-header ibuf-ext ibuffer ibuffer-loaddefs grep compile cus-edit pp
cus-load wid-edit ace-window avy beacon git-timemachine vc-git
vc-dispatcher git-gutter forge-list forge-commands forge-semi
forge-bitbucket buck forge-gogs gogs forge-gitea gtea forge-gitlab glab
forge-github ghub-graphql treepy gsexp ghub let-alist gnutls
forge-notify forge-revnote forge-pullreq forge-issue forge-topic yaml
bug-reference forge-post markdown-mode color thingatpt forge-repo forge
forge-core forge-db closql emacsql-sqlite emacsql emacsql-compiler
url-http url-auth url-gw nsm magit-submodule magit-obsolete magit-blame
magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch
magit-clone magit-remote magit-commit magit-sequence magit-notes
magit-worktree magit-tag magit-merge magit-branch magit-reset
magit-files magit-refs magit-status magit magit-repos magit-apply
magit-wip magit-log which-func imenu magit-diff smerge-mode diff
diff-mode git-commit rx log-edit message rmc puny dired dired-loaddefs
rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail
rmail-loaddefs text-property-search mm-decode mm-bodies mm-encode
mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr
mailabbrev mail-utils gmm-utils mailheader pcvs-util add-log magit-core
magit-autorevert autorevert filenotify magit-margin magit-transient
magit-process with-editor server magit-mode transient magit-git
magit-section magit-utils crm dash exec-path-from-shell try xterm-color
use-package-bind-key bind-key use-package-ensure use-package-core
ob-python python tramp-sh tramp tramp-loaddefs trampver
tramp-integration files-x tramp-compat parse-time iso8601 ls-lisp
ob-lisp ob-perl ob-shell shell org-tempo tempo edmacro kmacro paren
cl-extra help-mode org ob ob-tangle ob-ref ob-lob ob-table ob-exp
org-macro org-footnote org-src ob-comint org-pcomplete pcomplete comint
ansi-color ring org-list org-faces org-entities time-date noutline
outline easy-mmode org-version ob-emacs-lisp ob-core ob-eval org-table
ol org-keys org-compat advice org-macs org-loaddefs format-spec
find-func cal-menu calendar cal-loaddefs finder-inf info package
browse-url url url-proxy url-privacy url-expand url-methods url-history
url-cookie url-domsuf url-util mailcap url-handlers url-parse
auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs
password-cache json subr-x map url-vars seq byte-opt gv bytecomp
byte-compile cconv cl-loaddefs cl-lib iso-transl tooltip eldoc electric
uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu
timer select scroll-bar mouse jit-lock font-lock syntax font-core
term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese composite charscript charprop case-table epa-hook
jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button
loaddefs faces cus-face macroexp files window text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote threads dbusbind inotify lcms2
dynamic-setting system-font-setting font-render-setting cairo x-toolkit
x multi-tty make-network-process emacs)

Memory information:
((conses 16 734082 72287)
 (symbols 48 58598 21)
 (strings 32 240013 10188)
 (string-bytes 1 7509093)
 (vectors 16 113071)
 (vector-slots 8 1452366 146242)
 (floats 8 635 829)
 (intervals 56 13402 3671)
 (buffers 992 36))


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-keybinding-in-gnus-browse-map.patch --]
[-- Type: text/x-diff, Size: 1299 bytes --]

From a3e7c85ce9c06d730e48576a417d9b7611b3053b Mon Sep 17 00:00:00 2001
From: "Peder O. Klingenberg" <peder@klingenberg.no>
Date: Sat, 31 Jul 2021 23:58:21 +0200
Subject: [PATCH] Fix keybinding in gnus-browse-map.

* lisp/gnus/gnus-srvr.el (gnus-browse-mode-map):
Bind u to gnus-browse-toggle-subscription-at-point.
(gnus-browse-mode): Update documentation to match keymap.
---
 lisp/gnus/gnus-srvr.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/gnus/gnus-srvr.el b/lisp/gnus/gnus-srvr.el
index b316a2e86f..d34e5ec15e 100644
--- a/lisp/gnus/gnus-srvr.el
+++ b/lisp/gnus/gnus-srvr.el
@@ -716,7 +716,7 @@ gnus-browse-mode-map
     "\M-n" gnus-browse-next-group
     "\M-p" gnus-browse-prev-group
     "\r" gnus-browse-select-group
-    "u" gnus-browse-toggle-subscription
+    "u" gnus-browse-toggle-subscription-at-point
     "l" gnus-browse-exit
     "L" gnus-browse-exit
     "q" gnus-browse-exit
@@ -881,7 +881,7 @@ gnus-browse-mode
 \\<gnus-browse-mode-map>
 The only things you can do in this buffer is
 
-1) `\\[gnus-browse-toggle-subscription]' to subscribe or unsubscribe to
+1) `\\[gnus-browse-toggle-subscription-at-point]' to subscribe or unsubscribe to
 a group.  The group will be inserted into the group buffer upon exit from
 this buffer.
 
-- 
2.25.1

bug#49799: 28.0.50; u bound to wrong function in gnus-browse-mode-map

[Lars Ingebrigtsen]

"Peder O. Klingenberg" <peder@klingenberg.no> writes:

> A recent commit to gnus-srvr.el renamed two functions, one interactive,
> the other not.  u was previously bound to the interactive function, but
> after the renaming, it's bound to the non-interactive one.  This doesn't
> work so well.
>
> Attached is a patch.

Thanks; but I pushed almost exactly the same change a few minutes ago.  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#49799: 28.0.50; u bound to wrong function in gnus-browse-mode-map

[Peder O. Klingenberg]

On Sun, 2021-08-01 00:13:28 +0200, Lars Ingebrigtsen wrote:

> "Peder O. Klingenberg" <peder@klingenberg.no> writes:
>
>> A recent commit to gnus-srvr.el renamed two functions, one interactive,
>> the other not.  u was previously bound to the interactive function, but
>> after the renaming, it's bound to the non-interactive one.  This doesn't
>> work so well.
>>
>> Attached is a patch.
>
> Thanks; but I pushed almost exactly the same change a few minutes ago.  :-)

And I even made sure to pull the latest changes half an hour ago before
investigating.  Oh, well, great minds... :)


...Peder...
-- 
Sløv uten dop