From: Lars Ingebrigtsen <larsi@gnus.org>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: 54921@debbugs.gnu.org
Subject: bug#54921: eww/url mishandles IDN over proxy
Date: Fri, 15 Apr 2022 10:35:02 +0200 [thread overview]
Message-ID: <877d7qiw21.fsf@gnus.org> (raw)
In-Reply-To: <87h76vy37d.fsf@igel.home> (Andreas Schwab's message of "Thu, 14 Apr 2022 19:39:18 +0200")
Andreas Schwab <schwab@linux-m68k.org> writes:
> The proxy just receives the full URL in the GET request. Something like
> this, but puny-encode-domain must only be called with the domain name.
Right. Does the following untested patch work?
diff --git a/lisp/url/url-http.el b/lisp/url/url-http.el
index 96a4742956..b5bcd123c7 100644
--- a/lisp/url/url-http.el
+++ b/lisp/url/url-http.el
@@ -332,7 +332,10 @@ url-http-create-request
(if (and using-proxy
;; Bug#35969.
(not (equal "https" (url-type url-http-target-url))))
- (url-recreate-url url-http-target-url) real-fname))
+ (let ((url (copy-sequence url-http-target-url)))
+ (setf (url-host url) (puny-encode-domain (url-host url)))
+ (url-recreate-url url))
+ real-fname))
" HTTP/" url-http-version "\r\n"
;; Version of MIME we speak
"MIME-Version: 1.0\r\n"
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2022-04-15 8:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 21:42 bug#54921: eww/url mishandles IDN over proxy Andreas Schwab
2022-04-14 1:21 ` Lars Ingebrigtsen
2022-04-14 7:11 ` Andreas Schwab
2022-04-14 13:15 ` Lars Ingebrigtsen
2022-04-14 13:52 ` Andreas Schwab
2022-04-14 13:55 ` Lars Ingebrigtsen
2022-04-14 14:14 ` Andreas Schwab
2022-04-14 14:15 ` Lars Ingebrigtsen
2022-04-14 15:49 ` Andreas Schwab
2022-04-14 15:54 ` Lars Ingebrigtsen
2022-04-14 16:03 ` Andreas Schwab
2022-04-14 16:10 ` Lars Ingebrigtsen
2022-04-14 16:45 ` Andreas Schwab
2022-04-14 17:14 ` Lars Ingebrigtsen
2022-04-14 17:39 ` Andreas Schwab
2022-04-15 8:35 ` Lars Ingebrigtsen [this message]
2022-04-15 11:25 ` Andreas Schwab
2022-04-15 11:38 ` Lars Ingebrigtsen
2022-04-15 11:46 ` Andreas Schwab
2022-04-16 15:03 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877d7qiw21.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=54921@debbugs.gnu.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).