From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#54921: eww/url mishandles IDN over proxy Date: Fri, 15 Apr 2022 10:35:02 +0200 Message-ID: <877d7qiw21.fsf@gnus.org> References: <87bkx44q3v.fsf@igel.home> <87czhko3xg.fsf@gnus.org> <87bkx4yw98.fsf@igel.home> <87tuavn6vx.fsf@gnus.org> <877d7rzs92.fsf@igel.home> <87wnfrlqfx.fsf@gnus.org> <8735ifzr9q.fsf@igel.home> <874k2vlpim.fsf@gnus.org> <87tuavy8a8.fsf@igel.home> <87mtgnk6dn.fsf@gnus.org> <87pmljy7mt.fsf@igel.home> <87h76vk5m9.fsf@gnus.org> <87lew7y5po.fsf@igel.home> <874k2vk2p3.fsf@gnus.org> <87h76vy37d.fsf@igel.home> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7214"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 54921@debbugs.gnu.org To: Andreas Schwab Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 15 10:36:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nfHR4-0001d7-Uw for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Apr 2022 10:36:11 +0200 Original-Received: from localhost ([::1]:41338 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nfHR3-0001OD-Cy for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Apr 2022 04:36:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48774) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nfHQw-0001NB-Az for bug-gnu-emacs@gnu.org; Fri, 15 Apr 2022 04:36:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35956) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nfHQv-0002SP-Un for bug-gnu-emacs@gnu.org; Fri, 15 Apr 2022 04:36:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nfHQv-0007yK-Pz for bug-gnu-emacs@gnu.org; Fri, 15 Apr 2022 04:36:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Apr 2022 08:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54921 X-GNU-PR-Package: emacs Original-Received: via spool by 54921-submit@debbugs.gnu.org id=B54921.165001171430576 (code B ref 54921); Fri, 15 Apr 2022 08:36:01 +0000 Original-Received: (at 54921) by debbugs.gnu.org; 15 Apr 2022 08:35:14 +0000 Original-Received: from localhost ([127.0.0.1]:58086 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nfHQ9-0007x6-NB for submit@debbugs.gnu.org; Fri, 15 Apr 2022 04:35:13 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:49028) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nfHQ7-0007wo-IZ for 54921@debbugs.gnu.org; Fri, 15 Apr 2022 04:35:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1hrtTwni7wuguVxpDqd4H6PkvxbwVCDZUTT9w2QjoR4=; b=JwDILK1jx4g2QMLw0qLDp0qRN7 UK+gfeVMuoVIu3hmbJt3spYpeFIiiZyEx8tQIEMRzM8kuuWBWLhm9IfEntNaXRqpLR8n/fLnAC4g9 Ug7TqU1mtW3lCgeIrXRYa8G4VWT61QYuiuZf1ojcn6TuMk1ByyFMcfzsPGoB0h+dfwkM=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nfHPy-0008P8-Qd; Fri, 15 Apr 2022 10:35:05 +0200 In-Reply-To: <87h76vy37d.fsf@igel.home> (Andreas Schwab's message of "Thu, 14 Apr 2022 19:39:18 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:229920 Archived-At: Andreas Schwab writes: > The proxy just receives the full URL in the GET request. Something like > this, but puny-encode-domain must only be called with the domain name. Right. Does the following untested patch work? diff --git a/lisp/url/url-http.el b/lisp/url/url-http.el index 96a4742956..b5bcd123c7 100644 --- a/lisp/url/url-http.el +++ b/lisp/url/url-http.el @@ -332,7 +332,10 @@ url-http-create-request (if (and using-proxy ;; Bug#35969. (not (equal "https" (url-type url-http-target-url)))) - (url-recreate-url url-http-target-url) real-fname)) + (let ((url (copy-sequence url-http-target-url))) + (setf (url-host url) (puny-encode-domain (url-host url))) + (url-recreate-url url)) + real-fname)) " HTTP/" url-http-version "\r\n" ;; Version of MIME we speak "MIME-Version: 1.0\r\n" -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no