* bug#56659: 29.0.50; nitpicking: eldoc-doc-buffer should use special-mode
@ 2022-07-20 9:09 Zhiwei Chen
2022-07-23 7:13 ` Lars Ingebrigtsen
0 siblings, 1 reply; 3+ messages in thread
From: Zhiwei Chen @ 2022-07-20 9:09 UTC (permalink / raw)
To: 56659
M-x eldoc-doc-buffer displays `eldoc--doc-buffer', the ElDoc
documentation buffer, where
#+begin_src elisp
(local-set-key "q" 'quit-window)
#+end_src
is used to imitate the behavior of special-mode. Further more, using
special-mode for `eldoc-doc-buffer' gives users the opportunity to
modify the keymap, add-hook, ... etc. For myself, an evil-mode user,
it's able to press q in normal state to quit the window since
special-mode has already been evilified. Currently, evil adds an advice
after `eldoc-doc-buffer' [1] as a workaround.
[1]: https://github.com/emacs-evil/evil-collection/blob/master/modes/eldoc/evil-collection-eldoc.el#L60-L61=
--
Zhiwei Chen
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#56659: 29.0.50; nitpicking: eldoc-doc-buffer should use special-mode
2022-07-20 9:09 bug#56659: 29.0.50; nitpicking: eldoc-doc-buffer should use special-mode Zhiwei Chen
@ 2022-07-23 7:13 ` Lars Ingebrigtsen
2022-07-28 3:54 ` Zhiwei Chen
0 siblings, 1 reply; 3+ messages in thread
From: Lars Ingebrigtsen @ 2022-07-23 7:13 UTC (permalink / raw)
To: Zhiwei Chen; +Cc: 56659
Zhiwei Chen <condy0919@gmail.com> writes:
> is used to imitate the behavior of special-mode. Further more, using
> special-mode for `eldoc-doc-buffer' gives users the opportunity to
> modify the keymap, add-hook, ... etc. For myself, an evil-mode user,
> it's able to press q in normal state to quit the window since
> special-mode has already been evilified. Currently, evil adds an advice
> after `eldoc-doc-buffer' [1] as a workaround.
I've now fixed this in Emacs 29.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#56659: 29.0.50; nitpicking: eldoc-doc-buffer should use special-mode
2022-07-23 7:13 ` Lars Ingebrigtsen
@ 2022-07-28 3:54 ` Zhiwei Chen
0 siblings, 0 replies; 3+ messages in thread
From: Zhiwei Chen @ 2022-07-28 3:54 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 56659
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Zhiwei Chen <condy0919@gmail.com> writes:
>
>> is used to imitate the behavior of special-mode. Further more, using
>> special-mode for `eldoc-doc-buffer' gives users the opportunity to
>> modify the keymap, add-hook, ... etc. For myself, an evil-mode user,
>> it's able to press q in normal state to quit the window since
>> special-mode has already been evilified. Currently, evil adds an advice
>> after `eldoc-doc-buffer' [1] as a workaround.
>
> I've now fixed this in Emacs 29.
>
>
Thanks.
--
Zhiwei Chen
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-28 3:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-20 9:09 bug#56659: 29.0.50; nitpicking: eldoc-doc-buffer should use special-mode Zhiwei Chen
2022-07-23 7:13 ` Lars Ingebrigtsen
2022-07-28 3:54 ` Zhiwei Chen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).