unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Thierry Volpiatto <thievol@posteo.net>
Cc: 57334@debbugs.gnu.org
Subject: bug#57334: 28.1; Fix wdired with (dired '(dir f1 f2 ...))
Date: Mon, 22 Aug 2022 12:27:09 +0200	[thread overview]
Message-ID: <877d30bmki.fsf@gnus.org> (raw)
In-Reply-To: <878rng23aq.fsf@posteo.net> (Thierry Volpiatto's message of "Mon,  22 Aug 2022 06:23:52 +0000")

Thierry Volpiatto <thievol@posteo.net> writes:

> +                 (setcdr dired-directory
> +                         ;; Replace in `dired-directory' files that have
> +                         ;; been modified with their new name keeping
> +                         ;; the ones that are unmodified at the same place.
> +                         (cl-loop for f in (cdr dired-directory)
> +                                  collect (or (assoc-default f files-renamed)
> +                                              f)))))

This isn't obviously safe -- I think you're changing the list that
`dired' was originally called with here, which we shouldn't do.  (It may
even be a constant.)

So I think this should be changed to not do that.





  reply	other threads:[~2022-08-22 10:27 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-22  6:23 bug#57334: 28.1; Fix wdired with (dired '(dir f1 f2 ...)) Thierry Volpiatto
2022-08-22 10:27 ` Lars Ingebrigtsen [this message]
2022-08-22 14:42   ` Thierry Volpiatto
2022-08-22 14:54     ` Lars Ingebrigtsen
2022-08-22 14:59       ` Lars Ingebrigtsen
2022-08-22 15:45       ` Thierry Volpiatto
2022-08-22 15:56         ` Lars Ingebrigtsen
2022-08-22 18:46           ` Thierry Volpiatto
2022-08-22 18:49             ` Lars Ingebrigtsen
2022-08-22 20:05               ` Thierry Volpiatto
2022-08-23  4:50               ` Thierry Volpiatto
2022-08-23 10:04                 ` Lars Ingebrigtsen
2022-08-23 10:53                   ` Thierry Volpiatto
2022-08-22 11:26 ` Eli Zaretskii
2022-08-22 14:51   ` Thierry Volpiatto
2022-08-23  1:01 ` Michael Heerdegen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877d30bmki.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=57334@debbugs.gnu.org \
    --cc=thievol@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).