From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#57334: 28.1; Fix wdired with (dired '(dir f1 f2 ...)) Date: Mon, 22 Aug 2022 12:27:09 +0200 Message-ID: <877d30bmki.fsf@gnus.org> References: <878rng23aq.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32676"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 57334@debbugs.gnu.org To: Thierry Volpiatto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 22 12:28:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQ4fC-0008Gb-3F for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 Aug 2022 12:28:10 +0200 Original-Received: from localhost ([::1]:48304 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oQ4fB-0002sh-0t for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 Aug 2022 06:28:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47878) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQ4f4-0002rk-BQ for bug-gnu-emacs@gnu.org; Mon, 22 Aug 2022 06:28:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48239) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oQ4f3-0004TI-Pm for bug-gnu-emacs@gnu.org; Mon, 22 Aug 2022 06:28:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oQ4f3-0000mq-LZ for bug-gnu-emacs@gnu.org; Mon, 22 Aug 2022 06:28:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Aug 2022 10:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57334 X-GNU-PR-Package: emacs Original-Received: via spool by 57334-submit@debbugs.gnu.org id=B57334.16611640412954 (code B ref 57334); Mon, 22 Aug 2022 10:28:01 +0000 Original-Received: (at 57334) by debbugs.gnu.org; 22 Aug 2022 10:27:21 +0000 Original-Received: from localhost ([127.0.0.1]:37983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ4eO-0000la-O6 for submit@debbugs.gnu.org; Mon, 22 Aug 2022 06:27:21 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:52484) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ4eM-0000lL-Pl for 57334@debbugs.gnu.org; Mon, 22 Aug 2022 06:27:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8Kx5CfEEK6LL/dSB3J0dadQU0ijYBAefsUHfdXfCY60=; b=fp2TElGX/3iyIJ6N4yP5PNW1J1 //3IZAuuRiU55COlJeZi9UZyCcRIu+HKvvVGXSgkb5m5GkyszAVkgp6hFLzixyh51ptdTXMa4gRNY J3FyA2C3EDq4g7hpsEPRfUapFb0XV8P37FKyfdbfx9OgUO3wGZf3wWvEtrSujPgCBvyc=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQ4eE-0004Pn-7I; Mon, 22 Aug 2022 12:27:12 +0200 In-Reply-To: <878rng23aq.fsf@posteo.net> (Thierry Volpiatto's message of "Mon, 22 Aug 2022 06:23:52 +0000") X-Now-Playing: Bertine Zetlitz's _Sweet Injections_: "Blow over" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:240393 Archived-At: Thierry Volpiatto writes: > + (setcdr dired-directory > + ;; Replace in `dired-directory' files that have > + ;; been modified with their new name keeping > + ;; the ones that are unmodified at the same place. > + (cl-loop for f in (cdr dired-directory) > + collect (or (assoc-default f files-renamed) > + f))))) This isn't obviously safe -- I think you're changing the list that `dired' was originally called with here, which we shouldn't do. (It may even be a constant.) So I think this should be changed to not do that.