* bug#23601: [bisected] Emacs can't build after 2dc0ef29425b7
@ 2016-05-23 3:19 谢成骏
2016-05-23 9:00 ` Nicolas Petton
0 siblings, 1 reply; 6+ messages in thread
From: 谢成骏 @ 2016-05-23 3:19 UTC (permalink / raw)
To: 23601; +Cc: madper.xie
[-- Attachment #1: Type: text/plain, Size: 905 bytes --]
Hi All,
Yesterday my emacs failed to build.
Here is the error msg:
`````
(require seq) while preparing to dump
Makefile:545: recipe for target 'emacs' failed
make[1]: *** [emacs] Error 255
make[1]: Leaving directory '/home/madper/source/emacs/src'
Makefile:398: recipe for target 'src' failed
make: *** [src] Error 2
`````
After bisect I got:
`````
λ emacs 848d487 ✓ git bisect good
2dc0ef29425b7ee4c6c13b832c2a11dfe26ebb35 is the first bad commit
commit 2dc0ef29425b7ee4c6c13b832c2a11dfe26ebb35
Author: Nicolas Petton <nicolas@petton.fr>
Date: Sun May 22 21:51:11 2016 +0200
Add missing dependencies to seq.el
* lisp/emacs-lisp/find-func.el:
* lisp/ibuffer.el:
* lisp/image.el: Require seq.
:040000 040000 e3ae0052facd3cd6728259f6536363c0d0c9d70b 2105b394fefa44da3475d72f61be0f4f393ad985 M lisp
`````
Thanks a lot in advance,
Madper
[-- Attachment #2: Type: text/html, Size: 1144 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#23601: [bisected] Emacs can't build after 2dc0ef29425b7
2016-05-23 3:19 bug#23601: [bisected] Emacs can't build after 2dc0ef29425b7 谢成骏
@ 2016-05-23 9:00 ` Nicolas Petton
2016-05-23 15:35 ` Glenn Morris
0 siblings, 1 reply; 6+ messages in thread
From: Nicolas Petton @ 2016-05-23 9:00 UTC (permalink / raw)
To: 谢成骏, 23601; +Cc: madper.xie
[-- Attachment #1: Type: text/plain, Size: 322 bytes --]
谢成骏 <xiechj@mail2.sysu.edu.cn> writes:
> `````
> (require seq) while preparing to dump
> Makefile:545: recipe for target 'emacs' failed
> make[1]: *** [emacs] Error 255
I actually do not know why adding (require 'seq) to image.el makes the
build fail.
I can revert this commit in the meantime.
Nico
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#23601: [bisected] Emacs can't build after 2dc0ef29425b7
2016-05-23 9:00 ` Nicolas Petton
@ 2016-05-23 15:35 ` Glenn Morris
2016-05-23 15:54 ` Nicolas Petton
2016-05-23 15:56 ` Nicolas Petton
0 siblings, 2 replies; 6+ messages in thread
From: Glenn Morris @ 2016-05-23 15:35 UTC (permalink / raw)
To: Nicolas Petton; +Cc: madper.xie, 谢成骏, 23601
Nicolas Petton wrote:
> I actually do not know why adding (require 'seq) to image.el makes the
> build fail.
Files which are preloaded (ie, in loadup.el) cannot require any files
that are not themselves in loadup (because those required files would
then be preloaded too). This is an explicit check for such a case.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#23601: [bisected] Emacs can't build after 2dc0ef29425b7
2016-05-23 15:35 ` Glenn Morris
@ 2016-05-23 15:54 ` Nicolas Petton
2016-05-23 16:33 ` Eli Zaretskii
2016-05-23 15:56 ` Nicolas Petton
1 sibling, 1 reply; 6+ messages in thread
From: Nicolas Petton @ 2016-05-23 15:54 UTC (permalink / raw)
To: Glenn Morris; +Cc: madper.xie, 谢成骏, 23601
[-- Attachment #1: Type: text/plain, Size: 489 bytes --]
Glenn Morris <rgm@gnu.org> writes:
> Nicolas Petton wrote:
>
>> I actually do not know why adding (require 'seq) to image.el makes the
>> build fail.
>
> Files which are preloaded (ie, in loadup.el) cannot require any files
> that are not themselves in loadup (because those required files would
> then be preloaded too). This is an explicit check for such a case.
Ok, that makes sense. I'll remove the dependency to seq.el then in
image.el, I don't think it should be preloaded.
Nico
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#23601: [bisected] Emacs can't build after 2dc0ef29425b7
2016-05-23 15:35 ` Glenn Morris
2016-05-23 15:54 ` Nicolas Petton
@ 2016-05-23 15:56 ` Nicolas Petton
1 sibling, 0 replies; 6+ messages in thread
From: Nicolas Petton @ 2016-05-23 15:56 UTC (permalink / raw)
To: Glenn Morris; +Cc: madper.xie, 23601-done, 谢成骏, 23601
[-- Attachment #1: Type: text/plain, Size: 432 bytes --]
Glenn Morris <rgm@gnu.org> writes:
> Nicolas Petton wrote:
>
>> I actually do not know why adding (require 'seq) to image.el makes the
>> build fail.
>
> Files which are preloaded (ie, in loadup.el) cannot require any files
> that are not themselves in loadup (because those required files would
> then be preloaded too). This is an explicit check for such a case.
Commit c6493c6 fixes the problem, I'm closing this ticket.
Nico
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#23601: [bisected] Emacs can't build after 2dc0ef29425b7
2016-05-23 15:54 ` Nicolas Petton
@ 2016-05-23 16:33 ` Eli Zaretskii
0 siblings, 0 replies; 6+ messages in thread
From: Eli Zaretskii @ 2016-05-23 16:33 UTC (permalink / raw)
To: Nicolas Petton; +Cc: madper.xie, xiechj, 23601
> From: Nicolas Petton <nicolas@petton.fr>
> Date: Mon, 23 May 2016 17:54:10 +0200
> Cc: "madper.xie" <madper.xie@canonical.com>,
> 谢成骏 <xiechj@mail2.sysu.edu.cn>,
> 23601@debbugs.gnu.org
>
> I'll remove the dependency to seq.el then in image.el, I don't think
> it should be preloaded.
Yes, please. Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-05-23 16:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-23 3:19 bug#23601: [bisected] Emacs can't build after 2dc0ef29425b7 谢成骏
2016-05-23 9:00 ` Nicolas Petton
2016-05-23 15:35 ` Glenn Morris
2016-05-23 15:54 ` Nicolas Petton
2016-05-23 16:33 ` Eli Zaretskii
2016-05-23 15:56 ` Nicolas Petton
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).