From: Tom Tromey <tom@tromey.com>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 20896@debbugs.gnu.org, Tom Tromey <tom@tromey.com>,
Daniel Colascione <dan.colascione@gmail.com>
Subject: bug#20896: patch to add chained indentation
Date: Wed, 11 Jan 2017 21:01:53 -0700 [thread overview]
Message-ID: <8760llylhq.fsf@tromey.com> (raw)
In-Reply-To: <ab3bacd8-8c1f-e5e1-0982-b90e3874ecb7@yandex.ru> (Dmitry Gutov's message of "Thu, 12 Jan 2017 04:57:49 +0300")
>> It comes with some tests
Dmitry> I'd just like to point out that it's much better to write indentation
Dmitry> tests in the format used by test/manual/indent/js*.
Thanks, I wasn't aware of this. I'll redo the test this way.
>> (added to a file that first appears in patch in another
>> bug
Dmitry> Not sure which patch you mean. This file seems new.
I added js-tests.el in the bug#19399/bug#22431 patch, then further
amended it in bug#15582. None of these have landed yet. (There's also
bug#25389, which is related, but doesn't touch the test file.)
Dmitry> As for review: js--skip-term-backward seems to be doing something
Dmitry> similar to the loop in js--multi-line-declaration-indentation.
Dmitry> Maybe a extraction and unification is in order.
I don't really see it. Could you explain more?
Tom
next prev parent reply other threads:[~2017-01-12 4:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 15:37 bug#20896: 25.0.50; [js-mode][FR] support chain syntax indentation Rasmus
2015-06-26 0:14 ` Rasmus
2017-01-10 6:29 ` bug#20896: patch to add chained indentation Tom Tromey
2017-01-12 1:57 ` Dmitry Gutov
2017-01-12 4:01 ` Tom Tromey [this message]
2017-01-13 1:09 ` Dmitry Gutov
2017-01-14 17:45 ` bug#20896: done Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760llylhq.fsf@tromey.com \
--to=tom@tromey.com \
--cc=20896@debbugs.gnu.org \
--cc=dan.colascione@gmail.com \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).