From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tom Tromey Newsgroups: gmane.emacs.bugs Subject: bug#20896: patch to add chained indentation Date: Wed, 11 Jan 2017 21:01:53 -0700 Message-ID: <8760llylhq.fsf@tromey.com> References: <87a8vnlrxs.fsf@gmx.us> <87tw97zav3.fsf@tromey.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1484193810 24680 195.159.176.226 (12 Jan 2017 04:03:30 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 12 Jan 2017 04:03:30 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.90 (gnu/linux) Cc: 20896@debbugs.gnu.org, Tom Tromey , Daniel Colascione To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jan 12 05:03:25 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cRWbc-00059k-Li for geb-bug-gnu-emacs@m.gmane.org; Thu, 12 Jan 2017 05:03:16 +0100 Original-Received: from localhost ([::1]:59386 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cRWbh-0003g3-3R for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 Jan 2017 23:03:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37292) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cRWbS-0003ds-06 for bug-gnu-emacs@gnu.org; Wed, 11 Jan 2017 23:03:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cRWbO-00051q-Ru for bug-gnu-emacs@gnu.org; Wed, 11 Jan 2017 23:03:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35202) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cRWbO-00051m-OU for bug-gnu-emacs@gnu.org; Wed, 11 Jan 2017 23:03:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cRWbO-0004UQ-E0 for bug-gnu-emacs@gnu.org; Wed, 11 Jan 2017 23:03:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tom Tromey Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 Jan 2017 04:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20896 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20896-submit@debbugs.gnu.org id=B20896.148419373417175 (code B ref 20896); Thu, 12 Jan 2017 04:03:02 +0000 Original-Received: (at 20896) by debbugs.gnu.org; 12 Jan 2017 04:02:14 +0000 Original-Received: from localhost ([127.0.0.1]:50601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cRWac-0004Sx-8f for submit@debbugs.gnu.org; Wed, 11 Jan 2017 23:02:14 -0500 Original-Received: from gproxy9-pub.mail.unifiedlayer.com ([69.89.20.122]:40552 helo=gproxy9.mail.unifiedlayer.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cRWaa-0004Sj-62 for 20896@debbugs.gnu.org; Wed, 11 Jan 2017 23:02:12 -0500 Original-Received: from cmgw3 (unknown [10.0.90.84]) by gproxy9.mail.unifiedlayer.com (Postfix) with ESMTP id C38B51E10D4 for <20896@debbugs.gnu.org>; Wed, 11 Jan 2017 21:02:03 -0700 (MST) Original-Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id XG1y1u01p2f2jeq01G21dp; Wed, 11 Jan 2017 21:02:03 -0700 X-Authority-Analysis: v=2.1 cv=YpOcGeoX c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=IgFoBzBjUZAA:10 a=VjoE-u9KLxnY0IisJmQA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From; bh=b82M3hi/+xcHWiWad9Zeg5EOATNitp3FOS0dehNlxFM=; b=jxYPWia419dzlmwmvi9ArIlfws 0JJKGcedmZt/OFzYDhKDLu1zDybLz7aQRy+7xb2+tGt6hPJiO2KPj8UrHfl3KuvwmBvWlibYG4jnA K8y8zfEIuAVdoqKjq2Jhup2br; Original-Received: from 174-16-146-181.hlrn.qwest.net ([174.16.146.181]:43548 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1cRWaM-0005on-Kd; Wed, 11 Jan 2017 21:01:58 -0700 X-Attribution: Tom In-Reply-To: (Dmitry Gutov's message of "Thu, 12 Jan 2017 04:57:49 +0300") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.146.181 X-Exim-ID: 1cRWaM-0005on-Kd X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-146-181.hlrn.qwest.net (bapiya) [174.16.146.181]:43548 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:128028 Archived-At: >> It comes with some tests Dmitry> I'd just like to point out that it's much better to write indentation Dmitry> tests in the format used by test/manual/indent/js*. Thanks, I wasn't aware of this. I'll redo the test this way. >> (added to a file that first appears in patch in another >> bug Dmitry> Not sure which patch you mean. This file seems new. I added js-tests.el in the bug#19399/bug#22431 patch, then further amended it in bug#15582. None of these have landed yet. (There's also bug#25389, which is related, but doesn't touch the test file.) Dmitry> As for review: js--skip-term-backward seems to be doing something Dmitry> similar to the loop in js--multi-line-declaration-indentation. Dmitry> Maybe a extraction and unification is in order. I don't really see it. Could you explain more? Tom