* bug#19965: 24.3; diary-face-attrs and appt-warning-time-regexp cannot be combined
@ 2015-02-27 22:34 Stefan Reichör
2020-12-28 1:27 ` Lars Ingebrigtsen
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Reichör @ 2015-02-27 22:34 UTC (permalink / raw)
To: 19965
Hi Emacs Team,
I use two features of the diary:
a) The appointment warntime
,----
| 27/02/2015 23:45 Test ## warntime 30
`----
That way I can override the warntime for an entry
b) special text properties for the calendar view
,----
| 27/02/2015 23:45 Test [background:yellow]
`----
Now I want to combine both features.
I tried the following two variants, but they don't work:
,----
| 27/02/2015 23:45 Test ## warntime 30 [background:yellow]
`----
,----
| 27/02/2015 23:45 Test [background:yellow] ## warntime 30
`----
It would be really great to have a way to specify both features!
Thanks,
Stefan.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#19965: 24.3; diary-face-attrs and appt-warning-time-regexp cannot be combined
2015-02-27 22:34 bug#19965: 24.3; diary-face-attrs and appt-warning-time-regexp cannot be combined Stefan Reichör
@ 2020-12-28 1:27 ` Lars Ingebrigtsen
2020-12-28 14:34 ` Stefan Reichör
0 siblings, 1 reply; 6+ messages in thread
From: Lars Ingebrigtsen @ 2020-12-28 1:27 UTC (permalink / raw)
To: Stefan Reichör; +Cc: 19965
Stefan Reichör <stefan@xsteve.at> writes:
> I use two features of the diary:
>
> a) The appointment warntime
>
> ,----
> | 27/02/2015 23:45 Test ## warntime 30
> `----
>
> That way I can override the warntime for an entry
>
> b) special text properties for the calendar view
>
> ,----
> | 27/02/2015 23:45 Test [background:yellow]
> `----
>
> Now I want to combine both features.
>
> I tried the following two variants, but they don't work:
>
> ,----
> | 27/02/2015 23:45 Test ## warntime 30 [background:yellow]
(I'm going through old bug reports that unfortunately got no response at
the time.)
So you have a test case, starting from "emacs -Q", to reproduce this
bug? That'll be helpful when trying to fix this.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#19965: 24.3; diary-face-attrs and appt-warning-time-regexp cannot be combined
2020-12-28 1:27 ` Lars Ingebrigtsen
@ 2020-12-28 14:34 ` Stefan Reichör
2020-12-29 1:04 ` Lars Ingebrigtsen
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Reichör @ 2020-12-28 14:34 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 19965
Hi Lars!
Thanks a lot for going through old bugs.
This way you can reproduce the problem using "emacs -Q":
;; Content of ~/diary-test (adjust date + time to be a few minutes in the future):
12/28/2020 15:40 Test reminder, warntime used ## warntime 32
12/28/2020 15:41 Test reminder, colored [background:red]
12/28/2020 15:42 Test reminder combined1, not colored [background:red] ## warntime 34
12/28/2020 15:43 Test reminder combined2, not colored ## warntime 36 [background:red]
01/01/2021 New year [background:yellow]
(setq diary-file "~/diary-test")
(add-hook 'diary-display-hook 'fancy-diary-display)
(add-hook 'calendar-initial-window-hook 'diary-mark-entries)
(require 'appt)
(calendar)
;; force checking of appointments
(appt-check t)
;; appt-time-msg-list should contain the new appointment
(describe-variable 'appt-time-msg-list)
Stefan.
> Stefan Reichör <stefan@xsteve.at> writes:
>
>> I use two features of the diary:
>>
>> a) The appointment warntime
>>
>> ,----
>> | 27/02/2015 23:45 Test ## warntime 30
>> `----
>>
>> That way I can override the warntime for an entry
>>
>> b) special text properties for the calendar view
>>
>> ,----
>> | 27/02/2015 23:45 Test [background:yellow]
>> `----
>>
>> Now I want to combine both features.
>>
>> I tried the following two variants, but they don't work:
>>
>> ,----
>> | 27/02/2015 23:45 Test ## warntime 30 [background:yellow]
>
> (I'm going through old bug reports that unfortunately got no response at
> the time.)
>
> So you have a test case, starting from "emacs -Q", to reproduce this
> bug? That'll be helpful when trying to fix this.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#19965: 24.3; diary-face-attrs and appt-warning-time-regexp cannot be combined
2020-12-28 14:34 ` Stefan Reichör
@ 2020-12-29 1:04 ` Lars Ingebrigtsen
2020-12-29 18:25 ` Stefan Reichör
0 siblings, 1 reply; 6+ messages in thread
From: Lars Ingebrigtsen @ 2020-12-29 1:04 UTC (permalink / raw)
To: Stefan Reichör; +Cc: 19965
Stefan Reichör <stefan@xsteve.at> writes:
> This way you can reproduce the problem using "emacs -Q":
Thanks for the very clear bug reproduction case. It seems like the
diary code just assumed that the face attrs were at the end of the lines
(and weren't combined with comments), and just removing that limitation
seems to fix the test case. Fix pushed to Emacs 28.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#19965: 24.3; diary-face-attrs and appt-warning-time-regexp cannot be combined
2020-12-29 1:04 ` Lars Ingebrigtsen
@ 2020-12-29 18:25 ` Stefan Reichör
2020-12-30 3:03 ` Lars Ingebrigtsen
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Reichör @ 2020-12-29 18:25 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 19965
Hi Lars!
> Stefan Reichör <stefan@xsteve.at> writes:
>
>> This way you can reproduce the problem using "emacs -Q":
>
> Thanks for the very clear bug reproduction case. It seems like the
> diary code just assumed that the face attrs were at the end of the lines
> (and weren't combined with comments), and just removing that limitation
> seems to fix the test case. Fix pushed to Emacs 28.
Thanks for fixing this problem.
I can confirm that it works for me now :-)
Stefan.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-12-30 3:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-27 22:34 bug#19965: 24.3; diary-face-attrs and appt-warning-time-regexp cannot be combined Stefan Reichör
2020-12-28 1:27 ` Lars Ingebrigtsen
2020-12-28 14:34 ` Stefan Reichör
2020-12-29 1:04 ` Lars Ingebrigtsen
2020-12-29 18:25 ` Stefan Reichör
2020-12-30 3:03 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).