* bug#12986: Pressing backspace during isearch exits case-sensitive and word modes
@ 2012-11-25 1:55 Kelly Dean
2012-11-25 9:32 ` Juri Linkov
0 siblings, 1 reply; 9+ messages in thread
From: Kelly Dean @ 2012-11-25 1:55 UTC (permalink / raw)
To: 12986
Using 24.2, type:
onto to
Then do:
C-a C-s to
It highlights the first occurrence of "to" as the current match, and the second as the next match.
Then do: M-s w
Now, if you type a space, it continues in word mode as expected, but if instead you backspace over the o, it exits word mode. It shouldn't do that.
This same problem applies to case-sensitivity mode (M-c) too.
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#12986: Pressing backspace during isearch exits case-sensitive and word modes
2012-11-25 1:55 Kelly Dean
@ 2012-11-25 9:32 ` Juri Linkov
0 siblings, 0 replies; 9+ messages in thread
From: Juri Linkov @ 2012-11-25 9:32 UTC (permalink / raw)
To: Kelly Dean; +Cc: 12986
> Using 24.2, type:
> onto to
> Then do:
> C-a C-s to
> It highlights the first occurrence of "to" as the current match,
> and the second as the next match.
> Then do: M-s w
> Now, if you type a space, it continues in word mode as expected, but
> if instead you backspace over the o, it exits word mode. It shouldn't do that.
> This same problem applies to case-sensitivity mode (M-c) too.
<backspace> (isearch-delete-char) restores the previous search state.
If you want just to remove the last character from the search string,
you can type `C-M-w' (isearch-del-char).
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#12986: Pressing backspace during isearch exits case-sensitive and word modes
[not found] <1354124058.21763.YahooMailClassic@web141103.mail.bf1.yahoo.com>
@ 2012-11-28 23:15 ` Juri Linkov
2013-06-02 9:49 ` Juri Linkov
0 siblings, 1 reply; 9+ messages in thread
From: Juri Linkov @ 2012-11-28 23:15 UTC (permalink / raw)
To: Kelly Dean; +Cc: 12986
[please keep your replies Cc'd to 12986@debbugs.gnu.org]
>> <backspace> (isearch-delete-char) restores the previous search state.
>> If you want just to remove the last character from the search string,
>> you can type `C-M-w' (isearch-del-char).
> Sorry for the mistaken bug report. But it still seems to be a UI
> inconsistency: although the described behavior happens for word mode and
> case-insensitivity mode, it doesn't happen for regex mode, which it what
> led me to believe it was a bug for the first two. If it's supposed to
> happen for the first two, then shouldn't it happen for all three?
Good point. `isearch-delete-char' (that uses `isearch-pop-state')
restores word mode but not regexp mode. This looks like
unaccountable inconsistency. Perhaps it should restore
regexp mode as well.
Case-insensitivity is already restored when you type <backspace>
but you can't see this because it has no indication in the prompt.
Maybe it should momentarily flash a case sensitivity indicator
when you type <backspace> like it does when you type `M-c'
(but only when <backspace> changes the state of case-insensitivity).
The recently added `isearch-lax-whitespace' could be saved/restored too.
For customizability a new user option could be added to define a list
of search states that the user wants to keep on the isearch stack.
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#12986: Pressing backspace during isearch exits case-sensitive and word modes
2012-11-28 23:15 ` bug#12986: Pressing backspace during isearch exits case-sensitive and word modes Juri Linkov
@ 2013-06-02 9:49 ` Juri Linkov
2020-10-13 2:26 ` Lars Ingebrigtsen
0 siblings, 1 reply; 9+ messages in thread
From: Juri Linkov @ 2013-06-02 9:49 UTC (permalink / raw)
To: Kelly Dean; +Cc: 12986
>> But it still seems to be a UI inconsistency: although the described
>> behavior happens for word mode and case-insensitivity mode, it
>> doesn't happen for regex mode, which it what led me to believe it was
>> a bug for the first two. If it's supposed to happen for the first two,
>> then shouldn't it happen for all three?
>
> Good point. `isearch-delete-char' (that uses `isearch-pop-state')
> restores word mode but not regexp mode. This looks like
> unaccountable inconsistency. Perhaps it should restore
> regexp mode as well.
>
> Case-insensitivity is already restored when you type <backspace>
> but you can't see this because it has no indication in the prompt.
> Maybe it should momentarily flash a case sensitivity indicator
> when you type <backspace> like it does when you type `M-c'
> (but only when <backspace> changes the state of case-insensitivity).
>
> The recently added `isearch-lax-whitespace' could be saved/restored too.
>
> For customizability a new user option could be added to define a list
> of search states that the user wants to keep on the isearch stack.
This patch adds a new user option `isearch-keep-stack-variables'
intended to accompany another option `isearch-keep-mode-variables'
added in bug#11378. It adds a new option but doesn't change
the default behavior - its default value is `isearch-regexp'
that means to not keep regexp mode when pressing backspace
(other search variables will be supported later as well).
=== modified file 'lisp/isearch.el'
--- lisp/isearch.el 2013-05-30 23:50:36 +0000
+++ lisp/isearch.el 2013-06-02 09:45:01 +0000
@@ -153,6 +153,17 @@ (defcustom isearch-hide-immediately t
:type 'boolean
:group 'isearch)
+(defcustom isearch-keep-stack-variables '(isearch-regexp)
+ "A set of search variables to keep and not to restore from the search stack."
+ :type '(set (const :tag "Regexp search" isearch-regexp)
+ (const :tag "Case folding" isearch-case-fold-search)
+ (const :tag "Invisible text" isearch-invisible)
+ (const :tag "Filters" isearch-filter-predicates)
+ (const :tag "Lax whitespace" isearch-lax-whitespace)
+ (const :tag "Regexp lax whitespace" isearch-regexp-lax-whitespace))
+ :version "24.4"
+ :group 'isearch)
+
(defcustom isearch-resume-in-command-history nil
"If non-nil, `isearch-resume' commands are added to the command history.
This allows you to resume earlier Isearch sessions through the
@@ -1109,6 +1143,7 @@ (cl-defstruct (isearch--state
(case-fold-search isearch-case-fold-search)
(pop-fun (if isearch-push-state-function
(funcall isearch-push-state-function)))
+ (regexp isearch-regexp)
(filter-predicates isearch-filter-predicates))))
(string :read-only t)
(message :read-only t)
@@ -1122,6 +1157,7 @@ (cl-defstruct (isearch--state
(barrier :read-only t)
(case-fold-search :read-only t)
(pop-fun :read-only t)
+ (regexp :read-only t)
(filter-predicates :read-only t))
(defun isearch--set-state (cmd)
@@ -1136,6 +1172,8 @@ (defun isearch--set-state (cmd)
isearch-barrier (isearch--state-barrier cmd)
isearch-case-fold-search (isearch--state-case-fold-search cmd)
isearch-filter-predicates (isearch--state-filter-predicates cmd))
+ (unless (memq 'isearch-regexp isearch-keep-stack-variables)
+ (setq isearch-regexp (isearch--state-regexp cmd)))
(if (functionp (isearch--state-pop-fun cmd))
(funcall (isearch--state-pop-fun cmd) cmd))
(goto-char (isearch--state-point cmd)))
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#12986: Pressing backspace during isearch exits case-sensitive and word modes
2013-06-02 9:49 ` Juri Linkov
@ 2020-10-13 2:26 ` Lars Ingebrigtsen
2021-05-10 11:20 ` Lars Ingebrigtsen
0 siblings, 1 reply; 9+ messages in thread
From: Lars Ingebrigtsen @ 2020-10-13 2:26 UTC (permalink / raw)
To: Juri Linkov; +Cc: 12986, Kelly Dean
Juri Linkov <juri@jurta.org> writes:
>> Good point. `isearch-delete-char' (that uses `isearch-pop-state')
>> restores word mode but not regexp mode. This looks like
>> unaccountable inconsistency. Perhaps it should restore
>> regexp mode as well.
[...]
> This patch adds a new user option `isearch-keep-stack-variables'
> intended to accompany another option `isearch-keep-mode-variables'
> added in bug#11378. It adds a new option but doesn't change
> the default behavior - its default value is `isearch-regexp'
> that means to not keep regexp mode when pressing backspace
> (other search variables will be supported later as well).
I respun the patch for Emacs 28, but looking at it, I guess it doesn't
support actually restoring the modes it's discussing?
diff --git a/lisp/isearch.el b/lisp/isearch.el
index 0879f948cf..e9a3a2e921 100644
--- a/lisp/isearch.el
+++ b/lisp/isearch.el
@@ -167,6 +167,17 @@ isearch-hide-immediately
the search, with the exception of the last successful match, if any."
:type 'boolean)
+(defcustom isearch-keep-stack-variables '(isearch-regexp)
+ "A set of search variables to keep and not to restore from the search stack."
+ :type '(set (const :tag "Regexp search" isearch-regexp)
+ (const :tag "Case folding" isearch-case-fold-search)
+ (const :tag "Invisible text" isearch-invisible)
+ (const :tag "Filters" isearch-filter-predicates)
+ (const :tag "Lax whitespace" isearch-lax-whitespace)
+ (const :tag "Regexp lax whitespace" isearch-regexp-lax-whitespace))
+ :version "28.1"
+ :group 'isearch)
+
(defcustom isearch-resume-in-command-history nil
"If non-nil, `isearch-resume' commands are added to the command history.
This allows you to resume earlier Isearch sessions through the
@@ -1515,6 +1526,7 @@ isearch-update-from-string-properties
(case-fold-search isearch-case-fold-search)
(pop-fun (if isearch-push-state-function
(funcall isearch-push-state-function)))
+ (regexp isearch-regexp)
(match-data isearch-match-data))))
(string nil :read-only t)
(message nil :read-only t)
@@ -1528,6 +1540,7 @@ isearch-update-from-string-properties
(barrier nil :read-only t)
(case-fold-search nil :read-only t)
(pop-fun nil :read-only t)
+ (regexp :read-only t)
(match-data nil :read-only t))
(defun isearch--set-state (cmd)
@@ -1542,6 +1555,8 @@ isearch--set-state
isearch-barrier (isearch--state-barrier cmd)
isearch-case-fold-search (isearch--state-case-fold-search cmd)
isearch-match-data (isearch--state-match-data cmd))
+ (unless (memq 'isearch-regexp isearch-keep-stack-variables)
+ (setq isearch-regexp (isearch--state-regexp cmd)))
(if (functionp (isearch--state-pop-fun cmd))
(funcall (isearch--state-pop-fun cmd) cmd))
(goto-char (isearch--state-point cmd)))
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply related [flat|nested] 9+ messages in thread
* bug#12986: Pressing backspace during isearch exits case-sensitive and word modes
2020-10-13 2:26 ` Lars Ingebrigtsen
@ 2021-05-10 11:20 ` Lars Ingebrigtsen
2021-05-11 17:56 ` Juri Linkov
0 siblings, 1 reply; 9+ messages in thread
From: Lars Ingebrigtsen @ 2021-05-10 11:20 UTC (permalink / raw)
To: Juri Linkov; +Cc: 12986, Kelly Dean
Lars Ingebrigtsen <larsi@gnus.org> writes:
> I respun the patch for Emacs 28, but looking at it, I guess it doesn't
> support actually restoring the modes it's discussing?
But I guess since the companion patch in bug#11378 was never applied,
it's a moot issue. Juri, is this something that should still be worked
on, or has this patch (and the one in bug#11378) been abandoned?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#12986: Pressing backspace during isearch exits case-sensitive and word modes
2021-05-10 11:20 ` Lars Ingebrigtsen
@ 2021-05-11 17:56 ` Juri Linkov
2022-09-11 11:51 ` Lars Ingebrigtsen
0 siblings, 1 reply; 9+ messages in thread
From: Juri Linkov @ 2021-05-11 17:56 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 12986, Kelly Dean
>> I respun the patch for Emacs 28, but looking at it, I guess it doesn't
>> support actually restoring the modes it's discussing?
>
> But I guess since the companion patch in bug#11378 was never applied,
> it's a moot issue. Juri, is this something that should still be worked
> on, or has this patch (and the one in bug#11378) been abandoned?
This feature is currently under discussion with Augusto.
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#12986: Pressing backspace during isearch exits case-sensitive and word modes
2021-05-11 17:56 ` Juri Linkov
@ 2022-09-11 11:51 ` Lars Ingebrigtsen
2023-10-01 2:07 ` Stefan Kangas
0 siblings, 1 reply; 9+ messages in thread
From: Lars Ingebrigtsen @ 2022-09-11 11:51 UTC (permalink / raw)
To: Juri Linkov; +Cc: 12986, Kelly Dean
Juri Linkov <juri@jurta.org> writes:
>>> I respun the patch for Emacs 28, but looking at it, I guess it doesn't
>>> support actually restoring the modes it's discussing?
>>
>> But I guess since the companion patch in bug#11378 was never applied,
>> it's a moot issue. Juri, is this something that should still be worked
>> on, or has this patch (and the one in bug#11378) been abandoned?
>
> This feature is currently under discussion with Augusto.
This was a year ago -- was there any further progress?
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#12986: Pressing backspace during isearch exits case-sensitive and word modes
2022-09-11 11:51 ` Lars Ingebrigtsen
@ 2023-10-01 2:07 ` Stefan Kangas
0 siblings, 0 replies; 9+ messages in thread
From: Stefan Kangas @ 2023-10-01 2:07 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: Juri Linkov, 12986, Kelly Dean
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Juri Linkov <juri@jurta.org> writes:
>
>>>> I respun the patch for Emacs 28, but looking at it, I guess it doesn't
>>>> support actually restoring the modes it's discussing?
>>>
>>> But I guess since the companion patch in bug#11378 was never applied,
>>> it's a moot issue. Juri, is this something that should still be worked
>>> on, or has this patch (and the one in bug#11378) been abandoned?
>>
>> This feature is currently under discussion with Augusto.
>
> This was a year ago -- was there any further progress?
Another year has passed -- has there been any progress here?
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-10-01 2:07 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1354124058.21763.YahooMailClassic@web141103.mail.bf1.yahoo.com>
2012-11-28 23:15 ` bug#12986: Pressing backspace during isearch exits case-sensitive and word modes Juri Linkov
2013-06-02 9:49 ` Juri Linkov
2020-10-13 2:26 ` Lars Ingebrigtsen
2021-05-10 11:20 ` Lars Ingebrigtsen
2021-05-11 17:56 ` Juri Linkov
2022-09-11 11:51 ` Lars Ingebrigtsen
2023-10-01 2:07 ` Stefan Kangas
2012-11-25 1:55 Kelly Dean
2012-11-25 9:32 ` Juri Linkov
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).