unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Po Lu <luangruo@yahoo.com>
Cc: 51473@debbugs.gnu.org
Subject: bug#51473: [PATCH] Enable xwidget scrolling optimizations, and other xwidgets improvements
Date: Fri, 05 Nov 2021 00:11:58 +0100	[thread overview]
Message-ID: <875yt7plc1.fsf@gnus.org> (raw)
In-Reply-To: <87zgqslafe.fsf@yahoo.com> (Po Lu's message of "Fri, 29 Oct 2021 12:30:45 +0800")

Po Lu <luangruo@yahoo.com> writes:

> The attached changes fix flickering xwidgets by moving xwidget display
> into a separate X window, and also enable the scrolling optimization for
> xwidgets.

Sounds good...

> Someone with access to a Mac will have to do the changes necessary for
> xwidget scrolling to work correctly on macOS, as they don't work on
> GNUstep in the first place.

Does this mean that these patches will break the Macos build?

> However, event passthrough doesn't work yet, and will require some
> thought.  But that would be a fantastic opportunity to clean up the
> current xwidget event handling mess (and perhaps even define a mechanism
> for Lisp code to send events into xwidgets, which would make integrating
> them into the existing Emacs event model much easier.)  Any thoughts?

I'm not really that familiar with how xwidget works, so er does this
mean that the events work less with your patch than before?

I'm unable to test this at all, because:

larsi@elva:~/src/emacs/trunk$ emake;  ./src/emacs -geometry -0+0  
Overriding existing handler for signal 10. Set JSC_SIGNAL_FOR_GC if you want WebKit to use a different signal

** (emacs:2173922): ERROR **: 00:09:01.997: GApplication is required for xdg-desktop-portal access in the WebKit sandbox.
Fatal error 5: Trace/breakpoint trap


This is on Debian/bookwork.  (And without your patch, just building with
xwidget and `M-x xwidget-webkit-browse-url RET fsf.org RET', and Emacs
crashes.)  

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  parent reply	other threads:[~2021-11-04 23:11 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87zgqslafe.fsf.ref@yahoo.com>
2021-10-29  4:30 ` bug#51473: [PATCH] Enable xwidget scrolling optimizations, and other xwidgets improvements Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-29 13:18   ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-04 23:11   ` Lars Ingebrigtsen [this message]
2021-11-05  7:20     ` Eli Zaretskii
2021-11-05  7:29       ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-05  7:33         ` Lars Ingebrigtsen
2021-11-05  7:47           ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-05 13:35       ` Lars Ingebrigtsen
2021-11-05  7:34     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-05 13:10       ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-05 13:32         ` Lars Ingebrigtsen
2021-11-05 13:28       ` Lars Ingebrigtsen
2021-11-05 13:40         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-05 13:48           ` Lars Ingebrigtsen
2021-11-06  0:00             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-06  0:22             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-06  0:25               ` Lars Ingebrigtsen
2021-11-06  2:06                 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-06  5:39                 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-06  8:58                   ` Eli Zaretskii
2021-11-06 10:41                     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-06 17:42                       ` Lars Ingebrigtsen
2021-11-07  0:41                         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-07  0:55                           ` Lars Ingebrigtsen
2021-11-07  1:16                             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-07  1:04                           ` Lars Ingebrigtsen
2021-11-07  1:18                             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-07  1:23                               ` Lars Ingebrigtsen
2021-11-07  1:26                                 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-07  1:29                                   ` Lars Ingebrigtsen
2021-11-07  1:34                                     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-07  1:39                                       ` Lars Ingebrigtsen
2021-11-07  1:55                                         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-07  2:04                                           ` Lars Ingebrigtsen
2021-11-07 10:09                           ` Eli Zaretskii
2021-11-07 12:03                             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-07 12:33                               ` Eli Zaretskii
2021-11-07 12:40                                 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-07 12:52                                   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875yt7plc1.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=51473@debbugs.gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).