From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#51473: [PATCH] Enable xwidget scrolling optimizations, and other xwidgets improvements Date: Fri, 05 Nov 2021 00:11:58 +0100 Message-ID: <875yt7plc1.fsf@gnus.org> References: <87zgqslafe.fsf.ref@yahoo.com> <87zgqslafe.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15972"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 51473@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 05 00:13:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1milux-0003wr-3H for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Nov 2021 00:13:11 +0100 Original-Received: from localhost ([::1]:37434 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1miluv-0001Rr-Md for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Nov 2021 19:13:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53536) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1miluo-0001RU-3F for bug-gnu-emacs@gnu.org; Thu, 04 Nov 2021 19:13:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60549) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1milun-0004e9-R9 for bug-gnu-emacs@gnu.org; Thu, 04 Nov 2021 19:13:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1milun-0006MO-Kn for bug-gnu-emacs@gnu.org; Thu, 04 Nov 2021 19:13:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Nov 2021 23:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51473 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51473-submit@debbugs.gnu.org id=B51473.163606753124376 (code B ref 51473); Thu, 04 Nov 2021 23:13:01 +0000 Original-Received: (at 51473) by debbugs.gnu.org; 4 Nov 2021 23:12:11 +0000 Original-Received: from localhost ([127.0.0.1]:43862 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1miltz-0006L6-66 for submit@debbugs.gnu.org; Thu, 04 Nov 2021 19:12:11 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:60656) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1miltw-0006Kq-As for 51473@debbugs.gnu.org; Thu, 04 Nov 2021 19:12:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=eYbh6j2791/NJsZdF/uYACN0/DRqGBOvvnoUaOaBXJ4=; b=bqqPvTxBNsSdxlN4aakqm98RPE Q/7cp0Bt+Q/FqQj5JnVV2EYEwPZo3fS9tdKQ44gXJRBHgB+Lmqc9C8JIDEFzi0jhSpE2jei1fyWgt f3U789pcm5gZIAi0vPp9HfEGUTU/bvPr5Ei+5KtwlCON9OXcktaK/CqkqSMQpfzfAGmU=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1miltm-0007Lx-FW; Fri, 05 Nov 2021 00:12:02 +0100 X-Now-Playing: Chloe Thevenin & Pete Harden's _The Wire Tapper 57_: "Phantom Ride" In-Reply-To: <87zgqslafe.fsf@yahoo.com> (Po Lu's message of "Fri, 29 Oct 2021 12:30:45 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218953 Archived-At: Po Lu writes: > The attached changes fix flickering xwidgets by moving xwidget display > into a separate X window, and also enable the scrolling optimization for > xwidgets. Sounds good... > Someone with access to a Mac will have to do the changes necessary for > xwidget scrolling to work correctly on macOS, as they don't work on > GNUstep in the first place. Does this mean that these patches will break the Macos build? > However, event passthrough doesn't work yet, and will require some > thought. But that would be a fantastic opportunity to clean up the > current xwidget event handling mess (and perhaps even define a mechanism > for Lisp code to send events into xwidgets, which would make integrating > them into the existing Emacs event model much easier.) Any thoughts? I'm not really that familiar with how xwidget works, so er does this mean that the events work less with your patch than before? I'm unable to test this at all, because: larsi@elva:~/src/emacs/trunk$ emake; ./src/emacs -geometry -0+0 Overriding existing handler for signal 10. Set JSC_SIGNAL_FOR_GC if you want WebKit to use a different signal ** (emacs:2173922): ERROR **: 00:09:01.997: GApplication is required for xdg-desktop-portal access in the WebKit sandbox. Fatal error 5: Trace/breakpoint trap This is on Debian/bookwork. (And without your patch, just building with xwidget and `M-x xwidget-webkit-browse-url RET fsf.org RET', and Emacs crashes.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no