bug#51613: Eww buffer creation

bug#51613: Eww buffer creation

[André A. Gomes]

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

Hi Emacs,

I noticed that in order to open url-foo in a new buffer, I'd need to
call `(eww "url-foo" 4)`.  I understand that 4 is the universal
argument, but it looks cryptic (unless used interactively).  

Find my suggestion attached.  I took the opportunity to simplify the
underlying logic.


-- 
André A. Gomes
"Free Thought, Free World"

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-creation-of-eww-buffers.patch --]
[-- Type: text/x-patch, Size: 1066 bytes --]

From dd07c5b564effc5efd0ca2b1581694e32f5b9f14 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20A=2E=20Gomes?= <andremegafone@gmail.com>
Date: Fri, 5 Nov 2021 18:36:07 +0300
Subject: [PATCH] Fix creation of eww buffers.

---
 lisp/net/eww.el | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 74d3788116..3397b253e1 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -364,13 +364,9 @@ killed after rendering."
            (prefix-numeric-value current-prefix-arg))))
   (setq url (eww--dwim-expand-url url))
   (pop-to-buffer-same-window
-   (cond
-    ((eq arg 4)
-     (generate-new-buffer "*eww*"))
-    ((eq major-mode 'eww-mode)
-     (current-buffer))
-    (t
-     (get-buffer-create "*eww*"))))
+   (if (and (eq major-mode 'eww-mode) (null arg))
+       (current-buffer)
+     (generate-new-buffer "*eww*")))
   (eww-setup-buffer)
   ;; Check whether the domain only uses "Highly Restricted" Unicode
   ;; IDNA characters.  If not, transform to punycode to indicate that
-- 
2.33.1

bug#51613: Eww buffer creation

[Lars Ingebrigtsen]

André A. Gomes <andremegafone@gmail.com> writes:

> Find my suggestion attached.  I took the opportunity to simplify the
> underlying logic.

[...]

> +   (if (and (eq major-mode 'eww-mode) (null arg))
> +       (current-buffer)
> +     (generate-new-buffer "*eww*")))

I don't think that's correct?  Then `M-x eww' in a different buffer will
generate a new name.

So I've now fixed this in a different way in Emacs 29 (and renamed the
arguments to be more sensible).

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no