From: Lars Ingebrigtsen <larsi@gnus.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 52172@debbugs.gnu.org, Justin Schell <justinmschell@gmail.com>
Subject: bug#52172: Fix vc-git--program-version to support Git for macOS version string
Date: Mon, 06 Dec 2021 02:29:52 +0100 [thread overview]
Message-ID: <875ys2ldv3.fsf@gnus.org> (raw)
In-Reply-To: <86686f8f-9ec2-2047-46a1-dcc31d3cd1f8@yandex.ru> (Dmitry Gutov's message of "Mon, 6 Dec 2021 03:57:00 +0300")
Dmitry Gutov <dgutov@yandex.ru> writes:
> Looks good to me (especially with included tests). The
> trailing-dot-stripping approach, that is.
OK; I've now pushed it to Emacs 29.
> I would even suggest to try to get it into emacs-28 (given that
> apparently that functionality has been broken in macOS for a long
> time).
>
> But then again, if it's only been reported now, maybe it's not hugely
> important and Emacs 28 can live without it.
This sort of change can be somewhat ticklish, as it depends on output
from external programs, and it's hard to get full test coverage of that.
So I'd rather just put it on master.
Justin, this change was small enough to apply without assigning
copyright to the FSF, but for future patches you want to submit, it
might make sense to get the paperwork started now, so that subsequent
patches can be applied speedily. Would you be willing to sign such
paperwork?
next prev parent reply other threads:[~2021-12-06 1:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 1:44 bug#52172: Fix vc-git--program-version to support Git for macOS version string Justin Schell
2021-11-29 14:47 ` Lars Ingebrigtsen
2021-12-06 0:57 ` Dmitry Gutov
2021-12-06 1:29 ` Lars Ingebrigtsen [this message]
2021-12-06 1:44 ` Justin Schell
2021-12-06 1:52 ` Lars Ingebrigtsen
2021-12-06 0:58 ` Dmitry Gutov
2021-12-06 1:02 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875ys2ldv3.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=52172@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=justinmschell@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).