From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#52172: Fix vc-git--program-version to support Git for macOS version string Date: Mon, 06 Dec 2021 02:29:52 +0100 Message-ID: <875ys2ldv3.fsf@gnus.org> References: <87k0grxblx.fsf@gnus.org> <86686f8f-9ec2-2047-46a1-dcc31d3cd1f8@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28408"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 52172@debbugs.gnu.org, Justin Schell To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 06 02:31:42 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mu2r0-0007E9-3b for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Dec 2021 02:31:42 +0100 Original-Received: from localhost ([::1]:38846 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mu2qz-00054a-2N for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Dec 2021 20:31:41 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60536) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mu2qM-00052m-K8 for bug-gnu-emacs@gnu.org; Sun, 05 Dec 2021 20:31:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48550) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mu2qM-00052p-CP for bug-gnu-emacs@gnu.org; Sun, 05 Dec 2021 20:31:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mu2qM-0001cs-7v for bug-gnu-emacs@gnu.org; Sun, 05 Dec 2021 20:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Dec 2021 01:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52172 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 52172-submit@debbugs.gnu.org id=B52172.16387542032408 (code B ref 52172); Mon, 06 Dec 2021 01:31:02 +0000 Original-Received: (at 52172) by debbugs.gnu.org; 6 Dec 2021 01:30:03 +0000 Original-Received: from localhost ([127.0.0.1]:60086 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mu2pO-0000cL-NH for submit@debbugs.gnu.org; Sun, 05 Dec 2021 20:30:03 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:58522) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mu2pN-0000bB-E5 for 52172@debbugs.gnu.org; Sun, 05 Dec 2021 20:30:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=KsT7tQYaTQ+JetFO+sJmhMVWocMKOlq4QPsKGLciclo=; b=quUjJSAMlwdqoEKO83nBIt3FWa akeEN0hUwZumF2o0dhKxBrm7kLNE2UundzjmG3huVkQiHfAKaKuZk4zPcp+5QIjoc3bdVKJo79MGS GAIKNqYL5MBpAF3xSdmAB/f9b0XIQrEBKCZopNOVhNOlk7jDFfP10eiP0s4xtPvDwTcU=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mu2pE-0004rU-OM; Mon, 06 Dec 2021 02:29:55 +0100 X-Now-Playing: Neil Young & Crazy Horse's _Live Rust_: "Comes A Time" In-Reply-To: <86686f8f-9ec2-2047-46a1-dcc31d3cd1f8@yandex.ru> (Dmitry Gutov's message of "Mon, 6 Dec 2021 03:57:00 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:221697 Archived-At: Dmitry Gutov writes: > Looks good to me (especially with included tests). The > trailing-dot-stripping approach, that is. OK; I've now pushed it to Emacs 29. > I would even suggest to try to get it into emacs-28 (given that > apparently that functionality has been broken in macOS for a long > time). > > But then again, if it's only been reported now, maybe it's not hugely > important and Emacs 28 can live without it. This sort of change can be somewhat ticklish, as it depends on output from external programs, and it's hard to get full test coverage of that. So I'd rather just put it on master. Justin, this change was small enough to apply without assigning copyright to the FSF, but for future patches you want to submit, it might make sense to get the paperwork started now, so that subsequent patches can be applied speedily. Would you be willing to sign such paperwork?