bug#33117: 26.1; Scheme mode: Support lacking for imenu and indentation

bug#33117: 26.1; Scheme mode: Support lacking for imenu and indentation

[Pierre Neidhardt]

I've noticed that Scheme mode is lacking some important features.
For instance, `imenu-generic-expression' does not match `define-public'.

Alex Kost has compiled a bunch of fixes:

	https://gitlab.com/alezost-config/emacs/blob/master/utils/al-scheme.el

Should we merge those changes upstream?



In GNU Emacs 26.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.30)
 of 2018-10-08 built on localhost
Windowing system distributor 'The X.Org Foundation', version 11.0.12001000
Recent messages:
Sending via mail...
Sending email 
Sending email done
Mark set
Saving file /home/ambrevar/.cache/mail/mail/Sent/cur/1540223386.95e9c43d8195d02d.mimimi:2,S...
Wrote /home/ambrevar/.cache/emacs/places
Wrote /home/ambrevar/.cache/mail/mail/Sent/cur/1540223386.95e9c43d8195d02d.mimimi:2,S
Sending...done
[mu4e] Message sent
[mu4e] Found 1 matching message

Configured using:
 'configure
 CONFIG_SHELL=/gnu/store/rbrandv7anzjxqkr40d7fkanzssslk4b-bash-minimal-4.4.19/bin/bash
 SHELL=/gnu/store/rbrandv7anzjxqkr40d7fkanzssslk4b-bash-minimal-4.4.19/bin/bash
 --prefix=/gnu/store/812qcxpnjz17nbc0l3lsscma5dkjb96m-emacs-26.1
 --enable-fast-install'

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND DBUS GSETTINGS NOTIFY ACL
GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS
GTK3 X11 THREADS

Important settings:
  value of $LANG: en_US.utf8
  locale-coding-system: utf-8-unix

<#secure method=pgpmime mode=sign>

-- 
Pierre Neidhardt
https://ambrevar.xyz/

bug#33117: 26.1; Scheme mode: Support lacking for imenu and indentation

[Lars Ingebrigtsen]

Pierre Neidhardt <mail@ambrevar.xyz> writes:

> I've noticed that Scheme mode is lacking some important features.
> For instance, `imenu-generic-expression' does not match `define-public'.
>
> Alex Kost has compiled a bunch of fixes:
>
> 	https://gitlab.com/alezost-config/emacs/blob/master/utils/al-scheme.el
>
> Should we merge those changes upstream?

That sounds like a good idea.  Perhaps somebody could contact Kost and
ask whether these enhancements could be submitted as patches to scheme.el?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#33117: 26.1; Scheme mode: Support lacking for imenu and indentation

[Pierre Neidhardt]

[-- Attachment #1: Type: text/plain, Size: 555 bytes --]

>> I've noticed that Scheme mode is lacking some important features.
>> For instance, `imenu-generic-expression' does not match `define-public'.
>>
>> Alex Kost has compiled a bunch of fixes:
>>
>> 	https://gitlab.com/alezost-config/emacs/blob/master/utils/al-scheme.el
>>
>> Should we merge those changes upstream?
>
> That sounds like a good idea.  Perhaps somebody could contact Kost and
> ask whether these enhancements could be submitted as patches to scheme.el?

Alex, what do you think?

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#33117: 26.1; Scheme mode: Support lacking for imenu and indentation

[Alex Kost]

Pierre Neidhardt (2019-10-09 10:32 +0200) wrote:

>>> I've noticed that Scheme mode is lacking some important features.
>>> For instance, `imenu-generic-expression' does not match `define-public'.
>>>
>>> Alex Kost has compiled a bunch of fixes:
>>>
>>> 	https://gitlab.com/alezost-config/emacs/blob/master/utils/al-scheme.el
>>>
>>> Should we merge those changes upstream?
>>
>> That sounds like a good idea.  Perhaps somebody could contact Kost and
>> ask whether these enhancements could be submitted as patches to scheme.el?
>
> Alex, what do you think?

Sure, if you find that file useful, please take it, I don't mind of
course.

-- 
Alex

bug#33117: 26.1; Scheme mode: Support lacking for imenu and indentation

[Lars Ingebrigtsen]

Alex Kost <alezost@gmail.com> writes:

> Pierre Neidhardt (2019-10-09 10:32 +0200) wrote:
>
>>>> 	https://gitlab.com/alezost-config/emacs/blob/master/utils/al-scheme.el
>>>>
>>>> Should we merge those changes upstream?
>>>
>>> That sounds like a good idea.  Perhaps somebody could contact Kost and
>>> ask whether these enhancements could be submitted as patches to scheme.el?
>>
>> Alex, what do you think?
>
> Sure, if you find that file useful, please take it, I don't mind of
> course.

Great!  To include that much code, we would need copyright assignments
for the FSF.  Would you be willing to sign that?

We'd also need somebody to create a patch out of the changes to apply to
the Emacs code base.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#33117: 26.1; Scheme mode: Support lacking for imenu and indentation

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Mon, 14 Oct 2019 08:32:44 +0200
> Cc: Pierre Neidhardt <mail@ambrevar.xyz>, 33117@debbugs.gnu.org
> 
> Alex Kost <alezost@gmail.com> writes:
> 
> > Pierre Neidhardt (2019-10-09 10:32 +0200) wrote:
> >
> >>>> 	https://gitlab.com/alezost-config/emacs/blob/master/utils/al-scheme.el
> >>>>
> >>>> Should we merge those changes upstream?
> >>>
> >>> That sounds like a good idea.  Perhaps somebody could contact Kost and
> >>> ask whether these enhancements could be submitted as patches to scheme.el?
> >>
> >> Alex, what do you think?
> >
> > Sure, if you find that file useful, please take it, I don't mind of
> > course.
> 
> Great!  To include that much code, we would need copyright assignments
> for the FSF.  Would you be willing to sign that?

Alex has an assignment on file, so that part is already taken care of.

bug#33117: 26.1; Scheme mode: Support lacking for imenu and indentation

[Lars Ingebrigtsen]

Alex Kost <alezost@gmail.com> writes:

> Sure, if you find that file useful, please take it, I don't mind of
> course.

I've now updated scheme-imenu-generic-expression from Alex's version in
Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no