unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Trent W. Buck" <trentbuck@gmail.com>
Cc: Philip Kaludercic <philipk@posteo.net>, 57376@debbugs.gnu.org
Subject: bug#57376: 28.1; rcirc-fill-flag ignored after 27->28 upgrade
Date: Wed, 24 Aug 2022 13:45:29 +0200	[thread overview]
Message-ID: <875yihoofa.fsf@gnus.org> (raw)
In-Reply-To: <87y1vekpyl.fsf@gmail.com> (Trent W. Buck's message of "Wed, 24 Aug 2022 18:25:54 +1000")

"Trent W. Buck" <trentbuck@gmail.com> writes:

> I just upgraded from 1:27.1+1-3.1 to 1:28.1+1-2~bpo11+1.2.
> Now, even though (setq rcirc-fill-flag nil) in my .emacs,
> I am getting hard wrapping.
>
> None of these (evaluated in-buffer with M-:) stopped new messages being
> hard-wrapped at 70 columns:
>
>    (setq rcirc-fill-flag nil)
>    (auto-fill-mode -1)
>    (defun rcirc-markup-fill (x y))  ; nop out this unwanted function
>    (defun rcirc-fill-paragraph (&optional x))  ; nop out this unwanted function

I haven't tested myself, but it seems like the code in this area was
changed by:

commit 849e71fd83fa8796198035464897bf2f28f6226c
Author:     Philip Kaludercic <philipk@posteo.net>
AuthorDate: Wed Jun 9 17:55:55 2021 +0200

    Implement server-time extension
    
    * rcirc.el (rcirc-implemented-capabilities): Add new capability
    (rcirc-print): Insert messages in the right position
    (rcirc-log): Use right time value
    (rcirc-markup-timestamp): Use right time value

In particular, this:

- 	    ;; squeeze spaces out of text before rcirc-text
-	    (fill-region fill-start
-			 (1- (or (next-single-property-change fill-start
-							      'rcirc-text)
-				 rcirc-prompt-end-marker)))

was changed to this:

+              ;; squeeze spaces out of text before rcirc-text
+              (fill-region (point-min) (point-max))

But I don't really know the code well.  Adding Philip to the CCs.





  reply	other threads:[~2022-08-24 11:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-24  8:25 bug#57376: 28.1; rcirc-fill-flag ignored after 27->28 upgrade Trent W. Buck
2022-08-24 11:45 ` Lars Ingebrigtsen [this message]
2022-08-25 15:34   ` Philip Kaludercic
2022-08-27  4:10     ` Trent W. Buck
2022-08-27  8:14       ` Philip Kaludercic
2022-08-27 13:22         ` Lars Ingebrigtsen
2022-08-27 13:37           ` Philip Kaludercic
2022-09-24 14:58             ` Lars Ingebrigtsen
2022-09-24 15:51               ` Philip Kaludercic
2022-09-25  8:31               ` Philip Kaludercic
2022-09-26  0:33                 ` Trent W. Buck
2022-10-06 10:34                 ` Philip Kaludercic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875yihoofa.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=57376@debbugs.gnu.org \
    --cc=philipk@posteo.net \
    --cc=trentbuck@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).