From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#57376: 28.1; rcirc-fill-flag ignored after 27->28 upgrade Date: Wed, 24 Aug 2022 13:45:29 +0200 Message-ID: <875yihoofa.fsf@gnus.org> References: <87y1vekpyl.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2193"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Philip Kaludercic , 57376@debbugs.gnu.org To: "Trent W. Buck" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 24 13:58:08 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQp1L-0000PP-SN for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 Aug 2022 13:58:07 +0200 Original-Received: from localhost ([::1]:53880 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oQp1J-0001Bp-RU for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 Aug 2022 07:58:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46370) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQopf-0007k8-PK for bug-gnu-emacs@gnu.org; Wed, 24 Aug 2022 07:46:15 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56081) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oQopd-0005oz-Un for bug-gnu-emacs@gnu.org; Wed, 24 Aug 2022 07:46:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oQopd-0004QH-JY for bug-gnu-emacs@gnu.org; Wed, 24 Aug 2022 07:46:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Aug 2022 11:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57376 X-GNU-PR-Package: emacs Original-Received: via spool by 57376-submit@debbugs.gnu.org id=B57376.166134154216408 (code B ref 57376); Wed, 24 Aug 2022 11:46:01 +0000 Original-Received: (at 57376) by debbugs.gnu.org; 24 Aug 2022 11:45:42 +0000 Original-Received: from localhost ([127.0.0.1]:45824 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQopK-0004Fy-1J for submit@debbugs.gnu.org; Wed, 24 Aug 2022 07:45:42 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:48860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQopG-0003rn-QY for 57376@debbugs.gnu.org; Wed, 24 Aug 2022 07:45:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=P5LoWrk+cVbunbovAM+5Dg9Qg16akWiLGdi61+73QZY=; b=NJ3/o3DtJz56t3EFMvWigYulOe 0z3xDTUUgP6Ij1Jm+d3NoeRBy6dlKYMxTe1h4cT3T6xMrsKzKev2Ju7Vltq7VnVDVx81ZfJpNFcZJ UY7OhvvqCRLZZk69cNYrY7ndRY86iZttX79ilaZX6APWZ7e2/aHQmFUFw7KPND/Si5Xs=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQop7-0004yQ-Lx; Wed, 24 Aug 2022 13:45:31 +0200 In-Reply-To: <87y1vekpyl.fsf@gmail.com> (Trent W. Buck's message of "Wed, 24 Aug 2022 18:25:54 +1000") X-Now-Playing: Loma's _Don't Shy Away_: "Homing" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:240602 Archived-At: "Trent W. Buck" writes: > I just upgraded from 1:27.1+1-3.1 to 1:28.1+1-2~bpo11+1.2. > Now, even though (setq rcirc-fill-flag nil) in my .emacs, > I am getting hard wrapping. > > None of these (evaluated in-buffer with M-:) stopped new messages being > hard-wrapped at 70 columns: > > (setq rcirc-fill-flag nil) > (auto-fill-mode -1) > (defun rcirc-markup-fill (x y)) ; nop out this unwanted function > (defun rcirc-fill-paragraph (&optional x)) ; nop out this unwanted function I haven't tested myself, but it seems like the code in this area was changed by: commit 849e71fd83fa8796198035464897bf2f28f6226c Author: Philip Kaludercic AuthorDate: Wed Jun 9 17:55:55 2021 +0200 Implement server-time extension * rcirc.el (rcirc-implemented-capabilities): Add new capability (rcirc-print): Insert messages in the right position (rcirc-log): Use right time value (rcirc-markup-timestamp): Use right time value In particular, this: - ;; squeeze spaces out of text before rcirc-text - (fill-region fill-start - (1- (or (next-single-property-change fill-start - 'rcirc-text) - rcirc-prompt-end-marker))) was changed to this: + ;; squeeze spaces out of text before rcirc-text + (fill-region (point-min) (point-max)) But I don't really know the code well. Adding Philip to the CCs.