From: Philip Kaludercic <philipk@posteo.net>
To: "J.P." <jp@neverwas.me>
Cc: Lars Ingebrigtsen <larsi@gnus.org>,
57956@debbugs.gnu.org, Magnus Henoch <magnus.henoch@gmail.com>,
emacs-erc@gnu.org
Subject: bug#57956: 29.0.50; Add minimal authorization support to sasl-scram-rfc
Date: Fri, 23 Sep 2022 13:37:19 +0000 [thread overview]
Message-ID: <875yheus8g.fsf__49445.6146306888$1663940301$gmane$org@posteo.net> (raw)
In-Reply-To: <875yhggc5s.fsf@neverwas.me> (J. P.'s message of "Wed, 21 Sep 2022 23:23:43 -0700")
"J.P." <jp@neverwas.me> writes:
> Philip Kaludercic <philipk@posteo.net> writes:
>
>> "J.P." <jp@neverwas.me> writes:
>>
>>> is obviously an internal function. Does that matter? Would you rather we
>>> export it (as in rename it or alias it) beforehand (IOW, now)?
>>
>> I'd rather not add "internal functions" to Compat, at least in a way
>> that it would be exposed as part of the official Compat interface. That
>> being said, I am not familiar with the feature being discussed here,
>
> The feature (also a bug fix) being discussed here concerns the final
> client-side step of the SCRAM protocol. Basically, it computes a
> challenge from the server and packs the answer into an outgoing reply.
>
>> so maybe an exception has to be made?
>
> No reason to. We can keep it internal (the "final step" function, that
> is) and backport its logic, its helpers, and all (two-ish?) public
> functions that call it (I'm likely adding a third).
There should be no issue with adding two or three functions to Compat.
> Alternatively, we could
>
> - have ERC restrict this feature to users of Emacs 29+, or
> - stick with the status quo and manage this particular case manually via
> erc-comapt.el [1].
>
> I'd be fine with any of the above, really.
Do you think there is any interest in providing these functions outside
of ERC? If so, I think adding the code to Compat ought to be fine.
next prev parent reply other threads:[~2022-09-23 13:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <871qs62o0y.fsf@neverwas.me>
2022-09-20 15:28 ` bug#57956: 29.0.50; Add minimal authorization support to sasl-scram-rfc Lars Ingebrigtsen
[not found] ` <87tu52awv9.fsf@gnus.org>
2022-09-21 13:17 ` J.P.
[not found] ` <87a66ssw7s.fsf@neverwas.me>
2022-09-21 18:35 ` Philip Kaludercic
[not found] ` <871qs4mv7a.fsf@posteo.net>
2022-09-22 6:23 ` J.P.
[not found] ` <875yhggc5s.fsf@neverwas.me>
2022-09-23 13:37 ` Philip Kaludercic [this message]
[not found] ` <875yheus8g.fsf@posteo.net>
2022-09-28 1:22 ` J.P.
2022-10-26 13:13 ` J.P.
2022-09-20 13:06 J.P.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='875yheus8g.fsf__49445.6146306888$1663940301$gmane$org@posteo.net' \
--to=philipk@posteo.net \
--cc=57956@debbugs.gnu.org \
--cc=emacs-erc@gnu.org \
--cc=jp@neverwas.me \
--cc=larsi@gnus.org \
--cc=magnus.henoch@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).