From: Augusto Stoffel <arstoffel@gmail.com>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: Eli Zaretskii <eliz@gnu.org>,
58447@debbugs.gnu.org, Juri Linkov <juri@linkov.net>
Subject: bug#58447: [PATCH] In project-find-file, add absolute file name to history
Date: Fri, 18 Nov 2022 11:28:07 -0500 [thread overview]
Message-ID: <875yfcw7l4.fsf@gmail.com> (raw)
In-Reply-To: <336bb987-39c4-d911-8b07-7dd5cbae19c2@yandex.ru> (Dmitry Gutov's message of "Wed, 2 Nov 2022 00:14:18 +0200")
[-- Attachment #1: Type: text/plain, Size: 590 bytes --]
On Wed, 2 Nov 2022 at 00:14, Dmitry Gutov wrote:
> On 01.11.2022 19:30, Juri Linkov wrote:
>>> I'm not quite sure what Juri meant here. If from some project I do
>>>
>>> C-x p f /tmp RET RET
>>>
>>> then Emacs opens the /tmp dired buffer (RET twice because REQUIRE-MATCH
>>> is 'confirm), as I think it should.
>> Actually, that [Confirm] part is not quite a hassle, so your patch
>> already handles that in both ways, thanks for this.
>
> Thanks for verifying.
>
> LGTM then.
FTR, someone would have to install the patch on my behalf. I've
attached it again for your convenience.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-In-project-find-file-and-the-like-add-absolute-file-.patch --]
[-- Type: text/x-patch, Size: 1724 bytes --]
From 699732687f559c7984e76310971094f251423d5d Mon Sep 17 00:00:00 2001
From: Augusto Stoffel <arstoffel@gmail.com>
Date: Tue, 11 Oct 2022 20:21:34 +0200
Subject: [PATCH] In project-find-file and the like, add absolute file name to
history
* lisp/progmodes/project.el (project--read-file-cpd-relative): Add
absolute file name to history.
---
lisp/progmodes/project.el | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
index ee94d0d85d..95087ae6a8 100644
--- a/lisp/progmodes/project.el
+++ b/lisp/progmodes/project.el
@@ -931,11 +931,15 @@ project--read-file-cpd-relative
(_ (when included-cpd
(setq substrings (cons "./" substrings))))
(new-collection (project--file-completion-table substrings))
- (res (project--completing-read-strict prompt
- new-collection
- predicate
- hist mb-default)))
- (concat common-parent-directory res)))
+ (relname (let ((history-add-new-input nil))
+ (project--completing-read-strict prompt
+ new-collection
+ predicate
+ hist mb-default)))
+ (absname (expand-file-name relname common-parent-directory)))
+ (when (and hist history-add-new-input)
+ (add-to-history hist absname))
+ absname))
(defun project--read-file-absolute (prompt
all-files &optional predicate
--
2.37.3
next prev parent reply other threads:[~2022-11-18 16:28 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 18:29 bug#58447: [PATCH] In project-find-file, add absolute file name to history Augusto Stoffel
2022-10-11 19:13 ` Eli Zaretskii
2022-10-26 9:04 ` Augusto Stoffel
2022-10-27 8:44 ` Dmitry Gutov
2022-10-27 13:15 ` Eli Zaretskii
2022-10-27 14:21 ` Dmitry Gutov
2022-10-27 14:26 ` Augusto Stoffel
2022-10-27 15:36 ` Dmitry Gutov
2022-10-27 15:56 ` Augusto Stoffel
2022-10-27 16:07 ` Dmitry Gutov
2022-10-27 15:52 ` Eli Zaretskii
2022-10-27 16:10 ` Dmitry Gutov
2022-10-27 16:37 ` Augusto Stoffel
2022-10-27 16:48 ` Dmitry Gutov
2022-10-27 16:53 ` Augusto Stoffel
2022-10-27 17:34 ` Dmitry Gutov
2022-10-27 17:48 ` Augusto Stoffel
2022-10-27 18:05 ` Dmitry Gutov
2022-10-27 18:12 ` Augusto Stoffel
2022-10-27 19:51 ` Dmitry Gutov
2022-10-27 19:41 ` Juri Linkov
2022-10-28 18:11 ` Dmitry Gutov
2022-10-29 17:45 ` Juri Linkov
2022-10-30 19:42 ` Dmitry Gutov
2022-10-31 8:06 ` Augusto Stoffel
2022-11-01 17:30 ` Juri Linkov
2022-11-01 22:14 ` Dmitry Gutov
2022-11-18 16:28 ` Augusto Stoffel [this message]
2022-11-25 13:39 ` Eli Zaretskii
2022-11-26 2:28 ` Dmitry Gutov
2022-11-28 22:58 ` Augusto Stoffel
2022-11-29 16:29 ` Dmitry Gutov
2022-12-09 7:38 ` Juri Linkov
2022-12-09 13:00 ` Dmitry Gutov
2022-12-10 17:27 ` Juri Linkov
2022-12-10 19:50 ` Dmitry Gutov
2022-12-11 17:57 ` Juri Linkov
2022-12-11 18:14 ` Dmitry Gutov
2022-12-12 17:41 ` Juri Linkov
2022-12-12 18:49 ` Augusto Stoffel
2022-12-13 17:28 ` Juri Linkov
2022-12-14 16:47 ` Augusto Stoffel
2022-12-14 18:45 ` Dmitry Gutov
2022-12-14 19:32 ` Augusto Stoffel
2022-12-14 23:04 ` Dmitry Gutov
2022-12-15 7:24 ` Juri Linkov
2022-12-15 11:07 ` Augusto Stoffel
2022-12-15 14:04 ` Dmitry Gutov
2022-12-15 13:54 ` Dmitry Gutov
2022-12-15 17:24 ` Juri Linkov
2022-12-15 22:20 ` Dmitry Gutov
2022-12-16 7:48 ` Juri Linkov
2022-12-18 0:32 ` Dmitry Gutov
2022-12-15 11:07 ` Augusto Stoffel
2022-12-15 14:08 ` Dmitry Gutov
2022-12-15 17:21 ` Juri Linkov
2022-12-15 22:50 ` Dmitry Gutov
2022-12-18 8:36 ` Juri Linkov
2022-12-18 11:51 ` Dmitry Gutov
2022-12-19 17:55 ` Juri Linkov
2022-12-19 18:01 ` Eli Zaretskii
2022-12-19 19:48 ` Juri Linkov
2022-12-19 20:00 ` Eli Zaretskii
2022-12-19 19:18 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yfcw7l4.fsf@gmail.com \
--to=arstoffel@gmail.com \
--cc=58447@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=eliz@gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).