From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#58447: [PATCH] In project-find-file, add absolute file name to history Date: Fri, 18 Nov 2022 11:28:07 -0500 Message-ID: <875yfcw7l4.fsf@gmail.com> References: <8735budxiz.fsf@gmail.com> <83a662dvgo.fsf@gnu.org> <871qqvj6qb.fsf@gmail.com> <42bb91a0-60ff-2e51-dcdc-c1e1f80e31ec@yandex.ru> <837d0lmmpi.fsf@gnu.org> <1cce089a-546e-7f13-0907-3d36452aef10@yandex.ru> <83v8o5l0wa.fsf@gnu.org> <5c1cc828-5fcd-667f-41d4-f19923b2958e@yandex.ru> <87k04li5nw.fsf@gmail.com> <864jvphx4r.fsf@mail.linkov.net> <86tu3mftm0.fsf@mail.linkov.net> <875yg0to11.fsf@gmail.com> <86zgdalj0h.fsf@mail.linkov.net> <336bb987-39c4-d911-8b07-7dd5cbae19c2@yandex.ru> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27877"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 58447@debbugs.gnu.org, Juri Linkov To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 18 17:29:18 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ow4Ev-00073X-R8 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Nov 2022 17:29:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ow4Ei-0007Za-Df; Fri, 18 Nov 2022 11:29:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ow4Eg-0007ZG-HD for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2022 11:29:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ow4Eg-000848-9B for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2022 11:29:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ow4Eg-0000cg-2U for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2022 11:29:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Nov 2022 16:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58447 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58447-submit@debbugs.gnu.org id=B58447.16687889002343 (code B ref 58447); Fri, 18 Nov 2022 16:29:02 +0000 Original-Received: (at 58447) by debbugs.gnu.org; 18 Nov 2022 16:28:20 +0000 Original-Received: from localhost ([127.0.0.1]:38061 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ow4E0-0000bj-71 for submit@debbugs.gnu.org; Fri, 18 Nov 2022 11:28:20 -0500 Original-Received: from mail-qv1-f51.google.com ([209.85.219.51]:35733) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ow4Dw-0000bV-Bd for 58447@debbugs.gnu.org; Fri, 18 Nov 2022 11:28:19 -0500 Original-Received: by mail-qv1-f51.google.com with SMTP id i12so3680714qvs.2 for <58447@debbugs.gnu.org>; Fri, 18 Nov 2022 08:28:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=ejCiiBrTU4B8POqPVZu4aST1mFeFF8bSa2vcTislhs4=; b=qj+O9Lpta8pp0gS8o29tBLxnFq25s70H4AGSIw2IMnm6fCxr7BzkGd8QtCCO2Nmilc a1xesJw1eoh82pENDYTl1or7AJrocH29f9UZJg1h6+cbHlNW9lU42iozfzPz3BpbKJtQ YcZ+aE9uNucArHKCdBv/H2k5oSfx2kKAhNR4LkrEgLMzZ6X8lSWx0oo8BK6UrtXL0XRg UXZN+m8XGDEFMdSbQ0r9twoBUO2MsexQNplYnHljmvsL4ezNAZZhhCzRkXoDWAFDZaCQ BXQi+gOtv8NCL/El8FfLWebZVYaKRq/WxWCKOU4MedJDixXKOjP3D5AeQSmUYlguX+97 kj9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ejCiiBrTU4B8POqPVZu4aST1mFeFF8bSa2vcTislhs4=; b=igx2D7qneKZxkeWt5bDd5zbk1G9kmUMDarVE5TwUUb80UlhgCWLU352nscAWrr2G8Z VUByoxrsmscyRGLQDHO1gTl+yH0MnMIwuM74lIHRX+2gl5qIqhhfEl+rYymZZpljyG66 t4o6hYJUglqfrGofr2kaGDVUyjdadN0vB5PywSZUQY9tZlJBrO+JrRe7Cn1BZfeQoOgw j332A4Jyx+pBczLFgZc0BpRvslMaupQ8JsPRIpzU9zCMHLcHpw+s839uLiWq7AuXc9UD UwuTWqr24y5V8P1wf6qJQeKqVuMPqwsODBQd0K1f8gFAOuP4eruTw++UctprQtYwgmET MlSg== X-Gm-Message-State: ANoB5pk8ij71L5DHjtWPFc8EuxgnOoMLb+DCIYglkTqpBvXh9hb9f3hf Yy7K4QgPqV4bm91Xk9esFAaJb0GPtkXSpA== X-Google-Smtp-Source: AA0mqf4CPK5g0ZtdhZHU6RkaCnCo6xIPmQMYmKA/lUMixCSpWVIhs8zbAFR/9DAsyXGMs/3QkkQzFg== X-Received: by 2002:a0c:f604:0:b0:4ba:3ddb:a032 with SMTP id r4-20020a0cf604000000b004ba3ddba032mr7288428qvm.9.1668788890249; Fri, 18 Nov 2022 08:28:10 -0800 (PST) Original-Received: from ars3 ([2601:193:8201:6b70:ce48:802c:b8ef:d777]) by smtp.gmail.com with ESMTPSA id s68-20020ae9de47000000b006eed47a1a1esm2584139qkf.134.2022.11.18.08.28.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Nov 2022 08:28:09 -0800 (PST) In-Reply-To: <336bb987-39c4-d911-8b07-7dd5cbae19c2@yandex.ru> (Dmitry Gutov's message of "Wed, 2 Nov 2022 00:14:18 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248257 Archived-At: --=-=-= Content-Type: text/plain On Wed, 2 Nov 2022 at 00:14, Dmitry Gutov wrote: > On 01.11.2022 19:30, Juri Linkov wrote: >>> I'm not quite sure what Juri meant here. If from some project I do >>> >>> C-x p f /tmp RET RET >>> >>> then Emacs opens the /tmp dired buffer (RET twice because REQUIRE-MATCH >>> is 'confirm), as I think it should. >> Actually, that [Confirm] part is not quite a hassle, so your patch >> already handles that in both ways, thanks for this. > > Thanks for verifying. > > LGTM then. FTR, someone would have to install the patch on my behalf. I've attached it again for your convenience. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-In-project-find-file-and-the-like-add-absolute-file-.patch >From 699732687f559c7984e76310971094f251423d5d Mon Sep 17 00:00:00 2001 From: Augusto Stoffel Date: Tue, 11 Oct 2022 20:21:34 +0200 Subject: [PATCH] In project-find-file and the like, add absolute file name to history * lisp/progmodes/project.el (project--read-file-cpd-relative): Add absolute file name to history. --- lisp/progmodes/project.el | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index ee94d0d85d..95087ae6a8 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -931,11 +931,15 @@ project--read-file-cpd-relative (_ (when included-cpd (setq substrings (cons "./" substrings)))) (new-collection (project--file-completion-table substrings)) - (res (project--completing-read-strict prompt - new-collection - predicate - hist mb-default))) - (concat common-parent-directory res))) + (relname (let ((history-add-new-input nil)) + (project--completing-read-strict prompt + new-collection + predicate + hist mb-default))) + (absname (expand-file-name relname common-parent-directory))) + (when (and hist history-add-new-input) + (add-to-history hist absname)) + absname)) (defun project--read-file-absolute (prompt all-files &optional predicate -- 2.37.3 --=-=-=--