From: "J.P." <jp@neverwas.me>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 60954@debbugs.gnu.org, emacs-erc@gnu.org
Subject: bug#60954: 29.0.60; ERC 5.4.1: loading ERC clobbers customizations to erc-mode-hook
Date: Fri, 20 Jan 2023 06:14:17 -0800 [thread overview]
Message-ID: <875yd1uwcm.fsf__19159.632483364$1674224120$gmane$org@neverwas.me> (raw)
In-Reply-To: <83cz79oeu7.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 20 Jan 2023 09:16:48 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> I see two basic avenues of attack here. The first is a pretty safe
>> stopgap and the second a slightly riskier comprehensive approach that
>> should have been on the books the moment that bug was closed:
>>
>> hack: partially revert a tiny hunk from the commit above
>>
>> fix: don't require goodies at all and instead update the module
>> mapping data and add all necessary autoloads and forward
>> declarations
>>
>> Implementations of both are attached. (I didn't bother updating the
>> required Compat version in the second patch, but that'd also need to
>> accompany the change set.) For now, I propose we take the shorter route
>> but with an eye toward revisiting the issue soon after the next (ERC)
>> release. If anyone has an opinion here, now would be the time to speak
>> up.
>
> Your proposal is fine with me, thanks.
Great, thanks. I went ahead and added the lighter change to the release
branch.
Leaving this open until the rest is settled (whenever that may be).
next prev parent reply other threads:[~2023-01-20 14:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87pmb9wyz6.fsf@neverwas.me>
2023-01-20 7:16 ` bug#60954: 29.0.60; ERC 5.4.1: loading ERC clobbers customizations to erc-mode-hook Eli Zaretskii
[not found] ` <83cz79oeu7.fsf@gnu.org>
2023-01-20 14:14 ` J.P. [this message]
2023-01-20 14:15 ` J.P.
2023-01-21 15:03 ` bug#60954: 30.0.50; ERC >5.5: Stop requiring erc-goodies in erc.el J.P.
2023-01-31 15:27 ` J.P.
2023-02-07 15:22 ` J.P.
2023-02-19 15:07 ` J.P.
2023-03-09 14:43 ` J.P.
2023-03-14 13:32 ` J.P.
2023-03-15 14:04 ` J.P.
2023-01-20 5:34 bug#60954: 29.0.60; ERC 5.4.1: loading ERC clobbers customizations to erc-mode-hook J.P.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='875yd1uwcm.fsf__19159.632483364$1674224120$gmane$org@neverwas.me' \
--to=jp@neverwas.me \
--cc=60954@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=emacs-erc@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).