From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#60954: 29.0.60; ERC 5.4.1: loading ERC clobbers customizations to erc-mode-hook Date: Fri, 20 Jan 2023 06:14:17 -0800 Message-ID: <875yd1uwcm.fsf__19159.632483364$1674224120$gmane$org@neverwas.me> References: <87pmb9wyz6.fsf@neverwas.me> <83cz79oeu7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2700"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 60954@debbugs.gnu.org, emacs-erc@gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 20 15:15:11 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pIsAf-0000RD-Sx for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 20 Jan 2023 15:15:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pIsAZ-0004YT-TS; Fri, 20 Jan 2023 09:15:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIsAY-0004YB-Cu for bug-gnu-emacs@gnu.org; Fri, 20 Jan 2023 09:15:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pIsAX-0004aX-V7 for bug-gnu-emacs@gnu.org; Fri, 20 Jan 2023 09:15:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pIsAX-0001PL-Qr for bug-gnu-emacs@gnu.org; Fri, 20 Jan 2023 09:15:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Jan 2023 14:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60954 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60954-submit@debbugs.gnu.org id=B60954.16742240725353 (code B ref 60954); Fri, 20 Jan 2023 14:15:01 +0000 Original-Received: (at 60954) by debbugs.gnu.org; 20 Jan 2023 14:14:32 +0000 Original-Received: from localhost ([127.0.0.1]:45962 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIsA3-0001OG-KK for submit@debbugs.gnu.org; Fri, 20 Jan 2023 09:14:32 -0500 Original-Received: from mail-108-mta96.mxroute.com ([136.175.108.96]:45711) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIsA2-0001O3-9Y for 60954@debbugs.gnu.org; Fri, 20 Jan 2023 09:14:30 -0500 Original-Received: from mail-111-mta2.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta96.mxroute.com (ZoneMTA) with ESMTPSA id 185cf87c847000011e.001 for <60954@debbugs.gnu.org> (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Fri, 20 Jan 2023 14:14:20 +0000 X-Zone-Loop: eca4dccf981ca6d73044ba996dec105a810d9253a004 X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=XkNOmfrQktLKK7vbalxpmIqV7habNzPYDcyuZBAhalA=; b=hs07lU3Sgm2FsRrnJmoJNFjT7a 7Msn7UzKD6JGSO9jHc5TEtOvvIo0xxZm6xII1xLMt+Bg7qQC0P5312CfLSopMTGkCsg48AVVl8/lO TwTZz67YWPnK0WsdzsnqJl1GAVobxPUQETfI49NE32oB2S04JBqXYt7fRZF0bcu1Y1MFu/4C41NGn 0JcGot/jJ1bGgrVFjtKNxfBqlslpOqe9VztpnJLkHRTmGWL1lcQ4bQ/5ecdv4gA0FVOApSY5k1lZu kumDtV3yynWIHdqZoxuOzJA1SPA57lBbARNjc1BFQb0HKJCNgRmjIE9WLyaKXT5xzF26tB8LCjcof brjx0vsQ==; In-Reply-To: <83cz79oeu7.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 20 Jan 2023 09:16:48 +0200") X-Authenticated-Id: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253776 Archived-At: Eli Zaretskii writes: >> I see two basic avenues of attack here. The first is a pretty safe >> stopgap and the second a slightly riskier comprehensive approach that >> should have been on the books the moment that bug was closed: >> >> hack: partially revert a tiny hunk from the commit above >> >> fix: don't require goodies at all and instead update the module >> mapping data and add all necessary autoloads and forward >> declarations >> >> Implementations of both are attached. (I didn't bother updating the >> required Compat version in the second patch, but that'd also need to >> accompany the change set.) For now, I propose we take the shorter route >> but with an eye toward revisiting the issue soon after the next (ERC) >> release. If anyone has an opinion here, now would be the time to speak >> up. > > Your proposal is fine with me, thanks. Great, thanks. I went ahead and added the lighter change to the release branch. Leaving this open until the rest is settled (whenever that may be).