From: Philip Kaludercic <philipk@posteo.net>
To: Thuna <thuna.cing@gmail.com>
Cc: 60191@debbugs.gnu.org
Subject: bug#60191: [PATCH] Fix `rcirc-buffer-process' not working on channel buffers
Date: Mon, 01 May 2023 20:09:09 +0000 [thread overview]
Message-ID: <875y9bizkq.fsf@posteo.net> (raw)
In-Reply-To: <87lei7es1c.fsf@gmail.com> (Thuna's message of "Mon, 01 May 2023 22:05:35 +0200")
Thuna <thuna.cing@gmail.com> writes:
>> I do not understand what you mean by "not working" here, the code
>> appears to do the same thing pre- and post-patch, in the process and the
>> channel buffers.
>
> The problem is that when `rcirc-buffer-process' is explicitly called
> with a channel buffer it returns nil, as the local variable
> `rcirc-process' is set only in server buffers and the function checks
> the server buffer only if the BUFFER argument is nil.
>
> This leads to a situation where `(rcirc-buffer-process)' and
> `(rcirc-buffer-process (current-buffer))' do not behave in the same way
> when called from channel buffers.
OK, I get what you mean and the patch should be applied. But IIUC you
haven't signed the FSF CA, right? If that is so, I am afraid I am not
allowed to apply /your/ change myself...
next prev parent reply other threads:[~2023-05-01 20:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 8:47 bug#60191: [PATCH] Fix `rcirc-buffer-process' not working on channel buffers Thuna
2023-05-01 12:05 ` Philip Kaludercic
2023-05-01 20:05 ` Thuna
2023-05-01 20:09 ` Philip Kaludercic [this message]
2023-05-01 21:34 ` Thuna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875y9bizkq.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=60191@debbugs.gnu.org \
--cc=thuna.cing@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).