From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#60191: [PATCH] Fix `rcirc-buffer-process' not working on channel buffers Date: Mon, 01 May 2023 20:09:09 +0000 Message-ID: <875y9bizkq.fsf@posteo.net> References: <877cynrd8i.fsf@gmail.com> <875y9cqmtm.fsf@posteo.net> <87lei7es1c.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24102"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60191@debbugs.gnu.org To: Thuna Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 01 22:09:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ptZpi-00064v-4h for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 May 2023 22:09:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ptZpZ-0002VP-Sn; Mon, 01 May 2023 16:09:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptZpW-0002Uz-I8 for bug-gnu-emacs@gnu.org; Mon, 01 May 2023 16:09:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ptZpW-00034D-9h for bug-gnu-emacs@gnu.org; Mon, 01 May 2023 16:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ptZpV-00053U-MJ for bug-gnu-emacs@gnu.org; Mon, 01 May 2023 16:09:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 May 2023 20:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60191 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60191-submit@debbugs.gnu.org id=B60191.168297172619411 (code B ref 60191); Mon, 01 May 2023 20:09:01 +0000 Original-Received: (at 60191) by debbugs.gnu.org; 1 May 2023 20:08:46 +0000 Original-Received: from localhost ([127.0.0.1]:41135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptZpG-000531-0m for submit@debbugs.gnu.org; Mon, 01 May 2023 16:08:46 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:33691) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptZpD-00052n-Qi for 60191@debbugs.gnu.org; Mon, 01 May 2023 16:08:45 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 4F83F24017B for <60191@debbugs.gnu.org>; Mon, 1 May 2023 22:08:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1682971717; bh=Pq6E4zofao6f0oCB6GWP+j6tn2cI4W9k7DBGh8s9rYg=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=fY4TAw1z2JDO2sDHtHyLh5e2G156dM2x6WBukVTEumdSpM7q8Imm2xL7fEn+pCMK2 fh21orcuLVaH6S7dOO2OGP6UoG7IrnxpzhJadUYw2mfNwX6R/MwFp4UqiaW4marNqH IaT+Q4MqyGicny2/wKeTUn+7VN9Y0+yF/ds9ZvwW2Rxrq4Y++O6ktCxDpPoUm1BZ6e RgyXqezlCtPFL6gCE5ZF/QostsDnj1sXtBVtqbamWqXccLlboXHpI6mKkji+ch9SEF lHKUrDUqW7yHCNCo25GkIu4V89285J9bfDi+cUgMHh3NnTsS8Qq3p5ZBQYS++WmWJb sRYR7pzPcNvFA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Q9Dmh6sRqz9rxP; Mon, 1 May 2023 22:08:36 +0200 (CEST) In-Reply-To: <87lei7es1c.fsf@gmail.com> (Thuna's message of "Mon, 01 May 2023 22:05:35 +0200") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260892 Archived-At: Thuna writes: >> I do not understand what you mean by "not working" here, the code >> appears to do the same thing pre- and post-patch, in the process and the >> channel buffers. > > The problem is that when `rcirc-buffer-process' is explicitly called > with a channel buffer it returns nil, as the local variable > `rcirc-process' is set only in server buffers and the function checks > the server buffer only if the BUFFER argument is nil. > > This leads to a situation where `(rcirc-buffer-process)' and > `(rcirc-buffer-process (current-buffer))' do not behave in the same way > when called from channel buffers. OK, I get what you mean and the patch should be applied. But IIUC you haven't signed the FSF CA, right? If that is so, I am afraid I am not allowed to apply /your/ change myself...