* bug#66790: [BUG] org, ispell [9.6.6 (release_9.6.6 @ /Applications/Emacs.app/Contents/Resources/lisp/org/)] [not found] <230017B4-0868-4DF9-B834-72458C55DD82@gmail.com> @ 2023-11-05 11:58 ` Ihor Radchenko [not found] ` <87fs1k5s3t.fsf@localhost> 1 sibling, 0 replies; 3+ messages in thread From: Ihor Radchenko @ 2023-11-05 11:58 UTC (permalink / raw) To: Kai Jenkins; +Cc: emacs-orgmode, 66790 Kai Jenkins <jenkinskair@gmail.com> writes: > recipe to create bug: > - starting emacs (via. emacs -Q) > - open a new org file > - create a heading (eg. * test) > - write some text under the heading that contains a spelling mistake > - fold the heading with tab > - run M-x ispell > > the bug: > - ispell doesnt unfold the header that has the bug (possible corrections > are shown so it is finding the incorrect word) > - when you exit ispell with C-g the heading is now stuck and will not unfold with tab > - in the buffer theres a message "SUBTREE (NO CHILDREN)" Confirmed. At this point, I feel that supporting isearch + text properties is an uphill battle. I was hoping to contribute isearch.el patch upstream, but apparently numerous other libraries (ispell, regexp-search, evil, swiper) are relying upon invisibility being handled in very specific way, using overlays. Considering that using overlays is no longer slower compared to text properties in Emacs 29+, I am thinking of slowly switching back to using overlays for folding for newer Emacs versions. For your problem, just add (setq org-fold-core-style 'overlays) early in your config. It should fix the issue. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92> ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <87fs1k5s3t.fsf@localhost>]
* bug#66790: [BUG] org, ispell [9.6.6 (release_9.6.6 @ /Applications/Emacs.app/Contents/Resources/lisp/org/)] [not found] ` <87fs1k5s3t.fsf@localhost> @ 2024-05-02 11:36 ` Ihor Radchenko 2024-05-20 20:16 ` Stefan Kangas 0 siblings, 1 reply; 3+ messages in thread From: Ihor Radchenko @ 2024-05-02 11:36 UTC (permalink / raw) To: Kai Jenkins; +Cc: emacs-orgmode, 66790 Ihor Radchenko <yantar92@posteo.net> writes: > Confirmed. > > At this point, I feel that supporting isearch + text properties is an > uphill battle. I was hoping to contribute isearch.el patch upstream, but > apparently numerous other libraries (ispell, regexp-search, evil, > swiper) are relying upon invisibility being handled in very specific > way, using overlays. Considering that using overlays is no longer slower > compared to text properties in Emacs 29+, I am thinking of slowly > switching back to using overlays for folding for newer Emacs versions. Org mode development branch will have `org-fold-core-style' defaulting to 'overlays now as long as Emacs version is recent enough to handle overlays efficiently. Handled. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92> ^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#66790: [BUG] org, ispell [9.6.6 (release_9.6.6 @ /Applications/Emacs.app/Contents/Resources/lisp/org/)] 2024-05-02 11:36 ` Ihor Radchenko @ 2024-05-20 20:16 ` Stefan Kangas 0 siblings, 0 replies; 3+ messages in thread From: Stefan Kangas @ 2024-05-20 20:16 UTC (permalink / raw) To: Ihor Radchenko, Kai Jenkins; +Cc: 66790-done, emacs-orgmode Ihor Radchenko <yantar92@posteo.net> writes: > Ihor Radchenko <yantar92@posteo.net> writes: > >> Confirmed. >> >> At this point, I feel that supporting isearch + text properties is an >> uphill battle. I was hoping to contribute isearch.el patch upstream, but >> apparently numerous other libraries (ispell, regexp-search, evil, >> swiper) are relying upon invisibility being handled in very specific >> way, using overlays. Considering that using overlays is no longer slower >> compared to text properties in Emacs 29+, I am thinking of slowly >> switching back to using overlays for folding for newer Emacs versions. > > Org mode development branch will have `org-fold-core-style' defaulting > to 'overlays now as long as Emacs version is recent enough to handle > overlays efficiently. > > Handled. Thanks, I'm therefore closing this bug report. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-20 20:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <230017B4-0868-4DF9-B834-72458C55DD82@gmail.com>
2023-11-05 11:58 ` bug#66790: [BUG] org, ispell [9.6.6 (release_9.6.6 @ /Applications/Emacs.app/Contents/Resources/lisp/org/)] Ihor Radchenko
[not found] ` <87fs1k5s3t.fsf@localhost>
2024-05-02 11:36 ` Ihor Radchenko
2024-05-20 20:16 ` Stefan Kangas
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).