bug#4514: 23.1; defcustom ffap-rfc-path to match ffap-rfc-directories

bug#4514: 23.1; defcustom ffap-rfc-path to match ffap-rfc-directories

[Kevin Ryde]

[-- Attachment #1: Type: text/plain, Size: 147 bytes --]

2009-09-21  Kevin Ryde  <user42@zip.com.au>

	* ffap.el (ffap-rfc-path): Make this a defcustom since
	`ffap-rfc-directories' is also a defcustom.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: ffap.el.rfc-path-custom.diff --]
[-- Type: text/x-diff, Size: 1026 bytes --]

--- ffap.el.~1.85.~	2009-09-22 09:11:04.000000000 +1000
+++ ffap.el	2009-09-22 09:13:57.000000000 +1000
@@ -951,6 +951,16 @@
 		      "/pub/gnu/emacs/elisp-archive/"))
     (substring name 2))))
 
+(defcustom ffap-rfc-path
+  (concat (ffap-host-to-filename "ftp.rfc-editor.org") "/in-notes/rfc%s.txt")
+  "A `format' string making a filename for RFC documents.
+This can be an ange-ftp or tramp remote filename to download, or
+a local filename if you have full set of RFCs locally.  See also
+`ffap-rfc-directories'."
+  :type 'string
+  :version "23.1"
+  :group 'ffap)
+
 (defcustom ffap-rfc-directories nil
   "A list of directories to look for RFC files.
 If a given RFC isn't in these then `ffap-rfc-path' is offered."
@@ -958,9 +968,6 @@
   :version "23.1"
   :group 'ffap)
 
-(defvar ffap-rfc-path
-  (concat (ffap-host-to-filename "ftp.rfc-editor.org") "/in-notes/rfc%s.txt"))
-
 (defun ffap-rfc (name)
   (let ((num (match-string 1 name)))
     (or (ffap-locate-file (format "rfc%s.txt" num) t ffap-rfc-directories)

[-- Attachment #3: Type: text/plain, Size: 732 bytes --]



In GNU Emacs 23.1.1 (i486-pc-linux-gnu, GTK+ Version 2.16.5)
 of 2009-08-03 on raven, modified by Debian
configured using `configure  '--build=i486-linux-gnu' '--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.1/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.1/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS=''

bug#4514: 23.1; defcustom ffap-rfc-path to match ffap-rfc-directories

[Kevin Ryde]

I wrote:
>
> 	* ffap.el (ffap-rfc-path): Make this a defcustom since
> 	`ffap-rfc-directories' is also a defcustom.

If there's no violent objections to this I might check it in.

bug#4514: marked as done (23.1; defcustom ffap-rfc-path to match ffap-rfc-directories)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 900 bytes --]

Your message dated Sun, 06 Dec 2009 11:22:07 +1100
with message-id <87skbpvtn4.fsf@blah.blah>
and subject line Re: 23.1; defcustom ffap-rfc-path to match ffap-rfc-directories
has caused the Emacs bug report #4514,
regarding 23.1; defcustom ffap-rfc-path to match ffap-rfc-directories
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
4514: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4514
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 4425 bytes --]

[-- Attachment #2.1.1: Type: text/plain, Size: 147 bytes --]

2009-09-21  Kevin Ryde  <user42@zip.com.au>

	* ffap.el (ffap-rfc-path): Make this a defcustom since
	`ffap-rfc-directories' is also a defcustom.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2.1.2: ffap.el.rfc-path-custom.diff --]
[-- Type: text/x-diff, Size: 1026 bytes --]

--- ffap.el.~1.85.~	2009-09-22 09:11:04.000000000 +1000
+++ ffap.el	2009-09-22 09:13:57.000000000 +1000
@@ -951,6 +951,16 @@
 		      "/pub/gnu/emacs/elisp-archive/"))
     (substring name 2))))
 
+(defcustom ffap-rfc-path
+  (concat (ffap-host-to-filename "ftp.rfc-editor.org") "/in-notes/rfc%s.txt")
+  "A `format' string making a filename for RFC documents.
+This can be an ange-ftp or tramp remote filename to download, or
+a local filename if you have full set of RFCs locally.  See also
+`ffap-rfc-directories'."
+  :type 'string
+  :version "23.1"
+  :group 'ffap)
+
 (defcustom ffap-rfc-directories nil
   "A list of directories to look for RFC files.
 If a given RFC isn't in these then `ffap-rfc-path' is offered."
@@ -958,9 +968,6 @@
   :version "23.1"
   :group 'ffap)
 
-(defvar ffap-rfc-path
-  (concat (ffap-host-to-filename "ftp.rfc-editor.org") "/in-notes/rfc%s.txt"))
-
 (defun ffap-rfc (name)
   (let ((num (match-string 1 name)))
     (or (ffap-locate-file (format "rfc%s.txt" num) t ffap-rfc-directories)

[-- Attachment #2.1.3: Type: text/plain, Size: 732 bytes --]



In GNU Emacs 23.1.1 (i486-pc-linux-gnu, GTK+ Version 2.16.5)
 of 2009-08-03 on raven, modified by Debian
configured using `configure  '--build=i486-linux-gnu' '--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.1/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.1/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS=''

[-- Attachment #3: Type: message/rfc822, Size: 1799 bytes --]

From: Kevin Ryde <user42@zip.com.au>
To: 4514-done@emacsbugs.donarmstrong.com
Subject: Re: 23.1; defcustom ffap-rfc-path to match ffap-rfc-directories
Date: Sun, 06 Dec 2009 11:22:07 +1100
Message-ID: <87skbpvtn4.fsf@blah.blah>

Done.