unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Chong Yidong <cyd@gnu.org>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: 10087@debbugs.gnu.org
Subject: bug#10087: 24.0.91; gdb-create-source-file-list and the documented behaviour
Date: Mon, 26 Dec 2011 16:25:45 +0800	[thread overview]
Message-ID: <874nwnyc1i.fsf@gnu.org> (raw)
In-Reply-To: <87bos6hg75.fsf@linux.vnet.ibm.com>

> Don't we need to conditionalize gdb-get-source-file-list call ?  Also
> "ready" mode line update is done in that function. I guess that should
> be moved to gdb-get-source-file ?

IIUC, this was the bug that Nick was fixing in the following checkin, so
I'm closing it.  If it's not, please reopen.  Thanks.

revno: 106530
committer: Nick Roberts <nickrob@snap.net.nz>
branch nick: trunk
timestamp: Sun 2011-11-27 21:33:25 +1300
message:
  progmodes/gdb-mi.el (gdb-init-1): Condition execution of
  gdb-get-source-file-list on gdb-create-source-file-list.

=== modified file 'lisp/progmodes/gdb-mi.el'
*** lisp/progmodes/gdb-mi.el	2011-11-20 19:35:27 +0000
--- lisp/progmodes/gdb-mi.el	2011-11-27 08:33:25 +0000
***************
*** 873,885 ****
      (gdb-input (list "-gdb-set non-stop 1" 'gdb-non-stop-handler)))
  
    ;; find source file and compilation directory here
-   (gdb-input
-                                         ; Needs GDB 6.2 onwards.
-    (list "-file-list-exec-source-files" 'gdb-get-source-file-list))
    (if gdb-create-source-file-list
        (gdb-input
                                          ; Needs GDB 6.0 onwards.
!        (list "-file-list-exec-source-file" 'gdb-get-source-file)))
    (gdb-input
     (list "-gdb-show prompt" 'gdb-get-prompt)))
  
--- 873,885 ----
      (gdb-input (list "-gdb-set non-stop 1" 'gdb-non-stop-handler)))
  
    ;; find source file and compilation directory here
    (if gdb-create-source-file-list
        (gdb-input
+                                         ; Needs GDB 6.2 onwards.
+        (list "-file-list-exec-source-files" 'gdb-get-source-file-list)))
+   (gdb-input
                                          ; Needs GDB 6.0 onwards.
!    (list "-file-list-exec-source-file" 'gdb-get-source-file))
    (gdb-input
     (list "-gdb-show prompt" 'gdb-get-prompt)))
  






  reply	other threads:[~2011-12-26  8:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-20 17:11 bug#10087: 24.0.91; gdb-create-source-file-list and the documented behaviour Aneesh Kumar K.V
2011-12-26  8:25 ` Chong Yidong [this message]
2011-12-27 12:44   ` Aneesh Kumar K.V
2011-12-28  5:23     ` Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874nwnyc1i.fsf@gnu.org \
    --to=cyd@gnu.org \
    --cc=10087@debbugs.gnu.org \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).