From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#10087: 24.0.91; gdb-create-source-file-list and the documented behaviour Date: Mon, 26 Dec 2011 16:25:45 +0800 Message-ID: <874nwnyc1i.fsf@gnu.org> References: <87bos6hg75.fsf@linux.vnet.ibm.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1324888003 2581 80.91.229.12 (26 Dec 2011 08:26:43 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 26 Dec 2011 08:26:43 +0000 (UTC) Cc: 10087@debbugs.gnu.org To: "Aneesh Kumar K.V" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 26 09:26:35 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Rf5tC-0006Py-QV for geb-bug-gnu-emacs@m.gmane.org; Mon, 26 Dec 2011 09:26:35 +0100 Original-Received: from localhost ([::1]:36886 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rf5tC-0004P3-2r for geb-bug-gnu-emacs@m.gmane.org; Mon, 26 Dec 2011 03:26:34 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:57140) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rf5t9-0004Nm-Uc for bug-gnu-emacs@gnu.org; Mon, 26 Dec 2011 03:26:32 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rf5t8-0003nL-G8 for bug-gnu-emacs@gnu.org; Mon, 26 Dec 2011 03:26:31 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:52820) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rf5t8-0003nF-DC for bug-gnu-emacs@gnu.org; Mon, 26 Dec 2011 03:26:30 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Rf5vZ-00044A-IT for bug-gnu-emacs@gnu.org; Mon, 26 Dec 2011 03:29:01 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87bos6hg75.fsf@linux.vnet.ibm.com> Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Dec 2011 08:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10087 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 10087-submit@debbugs.gnu.org id=B10087.132488811115582 (code B ref 10087); Mon, 26 Dec 2011 08:29:01 +0000 Original-Received: (at 10087) by debbugs.gnu.org; 26 Dec 2011 08:28:31 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Rf5v4-00043G-4z for submit@debbugs.gnu.org; Mon, 26 Dec 2011 03:28:30 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Rf5v1-000439-OA for 10087@debbugs.gnu.org; Mon, 26 Dec 2011 03:28:28 -0500 Original-Received: from [155.69.16.4] (port=38713 helo=furball) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1Rf5sW-000878-5U; Mon, 26 Dec 2011 03:25:52 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 26 Dec 2011 03:29:01 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:55201 Archived-At: > Don't we need to conditionalize gdb-get-source-file-list call ? Also > "ready" mode line update is done in that function. I guess that should > be moved to gdb-get-source-file ? IIUC, this was the bug that Nick was fixing in the following checkin, so I'm closing it. If it's not, please reopen. Thanks. revno: 106530 committer: Nick Roberts branch nick: trunk timestamp: Sun 2011-11-27 21:33:25 +1300 message: progmodes/gdb-mi.el (gdb-init-1): Condition execution of gdb-get-source-file-list on gdb-create-source-file-list. === modified file 'lisp/progmodes/gdb-mi.el' *** lisp/progmodes/gdb-mi.el 2011-11-20 19:35:27 +0000 --- lisp/progmodes/gdb-mi.el 2011-11-27 08:33:25 +0000 *************** *** 873,885 **** (gdb-input (list "-gdb-set non-stop 1" 'gdb-non-stop-handler))) ;; find source file and compilation directory here - (gdb-input - ; Needs GDB 6.2 onwards. - (list "-file-list-exec-source-files" 'gdb-get-source-file-list)) (if gdb-create-source-file-list (gdb-input ; Needs GDB 6.0 onwards. ! (list "-file-list-exec-source-file" 'gdb-get-source-file))) (gdb-input (list "-gdb-show prompt" 'gdb-get-prompt))) --- 873,885 ---- (gdb-input (list "-gdb-set non-stop 1" 'gdb-non-stop-handler))) ;; find source file and compilation directory here (if gdb-create-source-file-list (gdb-input + ; Needs GDB 6.2 onwards. + (list "-file-list-exec-source-files" 'gdb-get-source-file-list))) + (gdb-input ; Needs GDB 6.0 onwards. ! (list "-file-list-exec-source-file" 'gdb-get-source-file)) (gdb-input (list "-gdb-show prompt" 'gdb-get-prompt)))