* bug#11706: 24.1.50; Wrong behavior of move-end-of-line in ERC
@ 2012-06-14 7:48 Antoine Levitt
2012-10-07 1:41 ` Glenn Morris
0 siblings, 1 reply; 2+ messages in thread
From: Antoine Levitt @ 2012-06-14 7:48 UTC (permalink / raw)
To: 11706
Hi,
(setq erc-timestamp-only-if-changed-flag nil
erc-hide-timestamps t
erc-insert-timestamp-function 'erc-insert-timestamp-left)
Join IRC, type a few line, then go back in the text and type C-e. Point
will stop one character before EOL. It's annoying.
My quick fix is
diff --git a/lisp/erc/erc-stamp.el b/lisp/erc/erc-stamp.el
index 5831233..b43b2b3 100644
--- a/lisp/erc/erc-stamp.el
+++ b/lisp/erc/erc-stamp.el
@@ -352,7 +352,7 @@ Return the empty string if FORMAT is nil."
'isearch-open-invisible 'timestamp ts)
;; N.B. Later use categories instead of this harmless, but
;; inelegant, hack. -- BPT
- (when erc-timestamp-intangible
+ (when (and erc-timestamp-intangible (not erc-hide-timestamps))
(erc-put-text-property 0 (length ts) 'intangible t ts))
ts)
""))
I think it's fine to install in trunk and certainly unlikely to cause
any further bugs (there's not much point in setting something invisible
as intangible), but I don't know very well how the code works, so I'd
appreciate it if someone could review it and fix the whole thing
consistently.
Antoine
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#11706: 24.1.50; Wrong behavior of move-end-of-line in ERC
2012-06-14 7:48 bug#11706: 24.1.50; Wrong behavior of move-end-of-line in ERC Antoine Levitt
@ 2012-10-07 1:41 ` Glenn Morris
0 siblings, 0 replies; 2+ messages in thread
From: Glenn Morris @ 2012-10-07 1:41 UTC (permalink / raw)
To: 11706-done
Version: 24.3
Thanks; applied to trunk.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-07 1:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-14 7:48 bug#11706: 24.1.50; Wrong behavior of move-end-of-line in ERC Antoine Levitt
2012-10-07 1:41 ` Glenn Morris
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).