* bug#16689: 24.3.50; Interactivity and nadvice
@ 2014-02-08 12:46 Nathan Trapuzzano
2014-02-13 2:10 ` Glenn Morris
0 siblings, 1 reply; 5+ messages in thread
From: Nathan Trapuzzano @ 2014-02-08 12:46 UTC (permalink / raw)
To: 16689
In replacgin all my `defadvice's with `advice-add's, I noticed the new
section in the manual doesn't go into any detail about how interactivity
(prefix commands, etc.) is maintained through the advice call chain.
Can this be added?
Nathan
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#16689: 24.3.50; Interactivity and nadvice
2014-02-08 12:46 bug#16689: 24.3.50; Interactivity and nadvice Nathan Trapuzzano
@ 2014-02-13 2:10 ` Glenn Morris
2014-02-14 1:14 ` Nathan Trapuzzano
0 siblings, 1 reply; 5+ messages in thread
From: Glenn Morris @ 2014-02-13 2:10 UTC (permalink / raw)
To: Nathan Trapuzzano; +Cc: 16689
Nathan Trapuzzano wrote:
> In replacgin all my `defadvice's with `advice-add's, I noticed the new
> section in the manual doesn't go into any detail about how interactivity
> (prefix commands, etc.) is maintained through the advice call chain.
I'm not sure it is the place of the manual to explain _how_ it works.
Could you say in more detail what you want to see added?
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#16689: 24.3.50; Interactivity and nadvice
2014-02-13 2:10 ` Glenn Morris
@ 2014-02-14 1:14 ` Nathan Trapuzzano
2014-02-14 10:20 ` Michael Heerdegen
2014-05-28 0:13 ` Stefan Monnier
0 siblings, 2 replies; 5+ messages in thread
From: Nathan Trapuzzano @ 2014-02-14 1:14 UTC (permalink / raw)
To: Glenn Morris; +Cc: 16689
Glenn Morris <rgm@gnu.org> writes:
> Nathan Trapuzzano wrote:
>
>> In replacgin all my `defadvice's with `advice-add's, I noticed the new
>> section in the manual doesn't go into any detail about how interactivity
>> (prefix commands, etc.) is maintained through the advice call chain.
>
> I'm not sure it is the place of the manual to explain _how_ it works.
> Could you say in more detail what you want to see added?
I'm talking about the interface. I believe the manual's old section on
defadvice talked about how to change a command's interactive behavior.
The nadvice section doesn't talk about any of that.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#16689: 24.3.50; Interactivity and nadvice
2014-02-14 1:14 ` Nathan Trapuzzano
@ 2014-02-14 10:20 ` Michael Heerdegen
2014-05-28 0:13 ` Stefan Monnier
1 sibling, 0 replies; 5+ messages in thread
From: Michael Heerdegen @ 2014-02-14 10:20 UTC (permalink / raw)
To: Nathan Trapuzzano; +Cc: 16689
Nathan Trapuzzano <nbtrap@nbtrap.com> writes:
> I'm talking about the interface. I believe the manual's old section on
> defadvice talked about how to change a command's interactive behavior.
> The nadvice section doesn't talk about any of that.
I do think so, too. What the docstring says:
If one of FUNCTION or OLDFUN is interactive, then the resulting function
is also interactive. There are 3 cases:
- FUNCTION is not interactive: the interactive spec of OLDFUN is used.
- The interactive spec of FUNCTION is itself a function: it should take one
argument (the interactive spec of OLDFUN, which it can pass to
`advice-eval-interactive-spec') and return the list of arguments to use.
- Else, use the interactive spec of FUNCTION and ignore the one of OLDFUN.
is already an exhaustive explanation, it could IMHO be used more or less
as is in the manual.
Michael.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#16689: 24.3.50; Interactivity and nadvice
2014-02-14 1:14 ` Nathan Trapuzzano
2014-02-14 10:20 ` Michael Heerdegen
@ 2014-05-28 0:13 ` Stefan Monnier
1 sibling, 0 replies; 5+ messages in thread
From: Stefan Monnier @ 2014-05-28 0:13 UTC (permalink / raw)
To: Nathan Trapuzzano; +Cc: 16689-done
> I'm talking about the interface. I believe the manual's old section on
> defadvice talked about how to change a command's interactive behavior.
> The nadvice section doesn't talk about any of that.
Closing: I believe the doc now does explain how the functions's
interactive-spec are combined.
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-05-28 0:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-08 12:46 bug#16689: 24.3.50; Interactivity and nadvice Nathan Trapuzzano
2014-02-13 2:10 ` Glenn Morris
2014-02-14 1:14 ` Nathan Trapuzzano
2014-02-14 10:20 ` Michael Heerdegen
2014-05-28 0:13 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).