unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#18834: references to (long time removed) eww-quit
@ 2014-10-25 16:47 Ivan Shmakov
  2014-11-02 21:03 ` Ted Zlatanov
  0 siblings, 1 reply; 2+ messages in thread
From: Ivan Shmakov @ 2014-10-25 16:47 UTC (permalink / raw)
  To: 18834

[-- Attachment #1: Type: text/plain, Size: 707 bytes --]

Package:  emacs
Severity: minor
Tags:     patch

	Git records show eww-quit and eww-exit being defined and
	redefined the last December.  Ultimately, however, both of these
	commands were removed from the code, – yet the references to
	them remain there to this day.

	Please thus consider the (untested) patch MIMEd, which is
	intended to complete the following change:

commit 4c004eaa87a1c9771a3ad07b382efbb81e380f96
Author:     Lars Magne Ingebrigtsen <larsi@gnus.org>
AuthorDate: Sun Dec 1 18:00:04 2013 +0100

    eww: Have `q' do a normal `quit-window' instead of killing the buffer.

	TIA.

-- 
FSF associate member #7257  http://boycottsystemd.org/  … 3013 B6A0 230E 334A

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/diff, Size: 565 bytes --]

--- eww.el
+++ eww.el
@@ -443,7 +443,7 @@
 
     (easy-menu-define nil map ""
       '("Eww"
-	["Exit" eww-quit t]
+	["Exit" quit-window t]
 	["Close browser" quit-window t]
 	["Reload" eww-reload t]
 	["Back to previous page" eww-back-url
@@ -463,7 +463,7 @@
 (defvar eww-tool-bar-map
   (let ((map (make-sparse-keymap)))
     (dolist (tool-bar-item
-             '((eww-quit . "close")
+             '((quit-window . "close")
                (eww-reload . "refresh")
                (eww-back-url . "left-arrow")
                (eww-forward-url . "right-arrow")

^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#18834: references to (long time removed) eww-quit
  2014-10-25 16:47 bug#18834: references to (long time removed) eww-quit Ivan Shmakov
@ 2014-11-02 21:03 ` Ted Zlatanov
  0 siblings, 0 replies; 2+ messages in thread
From: Ted Zlatanov @ 2014-11-02 21:03 UTC (permalink / raw)
  To: Ivan Shmakov; +Cc: 18834-done

On Sat, 25 Oct 2014 16:47:43 +0000 Ivan Shmakov <ivan@siamics.net> wrote: 

IS> -	["Exit" eww-quit t]
IS> +	["Exit" quit-window t]
IS> -             '((eww-quit . "close")
IS> +             '((quit-window . "close")

Thanks for the patch; applied in your name.  Closing.

Ted





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-11-02 21:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-25 16:47 bug#18834: references to (long time removed) eww-quit Ivan Shmakov
2014-11-02 21:03 ` Ted Zlatanov

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).