From: Noam Postavsky <npostavs@gmail.com>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: Stefan Kangas <stefan@marxist.se>,
40968@debbugs.gnu.org, Pip Cet <pipcet@gmail.com>
Subject: bug#40968: 28.0.50; (apply nil)
Date: Thu, 07 May 2020 07:54:10 -0400 [thread overview]
Message-ID: <874kssm04d.fsf@gmail.com> (raw)
In-Reply-To: <ECEC9424-919F-4364-9294-381C8751921A@acm.org> ("Mattias Engdegård"'s message of "Thu, 7 May 2020 11:11:00 +0200")
Mattias Engdegård <mattiase@acm.org> writes:
> 7 maj 2020 kl. 08.53 skrev Pip Cet <pipcet@gmail.com>:
>
>> It is incomplete. However, I've yet to find an elegant way to fix the
>> byte compiler and get it to emit the right error message. Can you
>> think of one?
>
> You are right, that's a puzzle. No, I cannot think of an elegant way
> (but a few inelegant ones).
The obvious solution is just to leave the weird single arg form
unoptimized. Otherwise, what about your earlier suggestion?
(apply X) == (apply (car X) (cdr X))
> It's probably not worth the trouble; just change the error test case
By the way, bytecomp-check-1 already ignores differences between error
types. So the test case doesn't need a condition-case at all if we
don't care about which particular error is signalled.
--- i/lisp/emacs-lisp/byte-opt.el
+++ w/lisp/emacs-lisp/byte-opt.el
@@ -1100,7 +1100,7 @@ byte-optimize-apply
;; The funcall optimizer can then transform (funcall 'foo ...) -> (foo ...).
(if (= (length form) 2)
;; single-argument `apply' is special (bug#40968)
- (byte-optimize-apply `(apply #'funcall ,(cadr form)))
+ (byte-optimize-apply `(apply (car ,(cadr form)) (cdr ,(cadr form))))
(let ((fn (nth 1 form))
(last (nth (1- (length form)) form))) ; I think this really is fastest
(or (if (or (null last)
diff --git i/src/eval.c w/src/eval.c
index 77f54ad7b1..836be7a906 100644
--- i/src/eval.c
+++ w/src/eval.c
@@ -2373,10 +2373,11 @@ DEFUN ("apply", Fapply, Sapply, 1, MANY, 0,
Lisp_Object fun = args[0];
USE_SAFE_ALLOCA;
- ptrdiff_t numargs = list_length (spread_arg);
+ if (nargs == 1)
+ /* Special case: FUN is really a list of (FUNCTION . ARGS). */
+ return CALLN (Fapply, CAR (fun), CDR (fun));
- if (numargs == 0 && nargs == 1)
- wrong_type_argument (Qconsp, spread_arg);
+ ptrdiff_t numargs = list_length (spread_arg);
if (numargs == 0)
return Ffuncall (nargs - 1, args);
next prev parent reply other threads:[~2020-05-07 11:54 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 18:26 bug#40968: 28.0.50; (apply nil) Pip Cet
2020-04-29 18:35 ` Pip Cet
2020-05-06 1:51 ` Stefan Kangas
2020-05-06 7:26 ` Pip Cet
2020-05-06 11:24 ` Stefan Kangas
2020-05-06 11:49 ` Pip Cet
2020-05-06 13:02 ` Stefan Kangas
2020-05-06 13:55 ` Pip Cet
2020-05-06 15:28 ` Stefan Kangas
2020-05-06 18:06 ` Pip Cet
2020-05-06 19:26 ` Drew Adams
2020-05-06 14:03 ` Eli Zaretskii
2020-05-06 17:54 ` Pip Cet
2020-05-06 18:09 ` Eli Zaretskii
2020-05-06 18:00 ` Drew Adams
2020-05-06 18:28 ` Noam Postavsky
2020-05-06 19:17 ` Drew Adams
2020-05-06 19:21 ` Pip Cet
2020-05-06 19:28 ` Drew Adams
2020-05-07 2:27 ` Eli Zaretskii
2020-05-06 17:46 ` Drew Adams
2020-05-06 20:32 ` Phil Sainty
2020-05-06 21:35 ` Drew Adams
2020-09-29 3:00 ` Stefan Monnier
2020-05-06 10:18 ` Mattias Engdegård
2020-05-06 10:45 ` Eli Zaretskii
2020-05-06 10:57 ` Andreas Schwab
2020-05-06 11:25 ` Pip Cet
2020-05-06 11:49 ` Mattias Engdegård
2020-05-06 18:42 ` Mattias Engdegård
2020-05-07 6:53 ` Pip Cet
2020-05-07 9:11 ` Mattias Engdegård
2020-05-07 11:54 ` Noam Postavsky [this message]
2020-05-07 11:58 ` Pip Cet
2020-05-07 12:20 ` Noam Postavsky
2020-05-07 13:53 ` Mattias Engdegård
2020-06-02 7:36 ` Pip Cet
2020-06-02 16:32 ` Drew Adams
2020-06-02 16:43 ` Eli Zaretskii
2020-06-02 16:36 ` Eli Zaretskii
2020-09-27 15:01 ` Lars Ingebrigtsen
2020-09-27 19:28 ` Drew Adams
[not found] <<CC40D602-5027-40A7-9BAB-1AADC9E4BDAE@acm.org>
[not found] ` <<CAOqdjBfj6AExvem5WWLfMiw4fEsY-xUUmosV+fj9CaPgWM16ag@mail.gmail.com>
[not found] ` <<ECEC9424-919F-4364-9294-381C8751921A@acm.org>
[not found] ` <<874kssm04d.fsf@gmail.com>
[not found] ` <<6ADF0807-7EBD-4054-8579-4D9AD3065D51@acm.org>
[not found] ` <<CAOqdjBdQne3RFTjg4hej40L5aeBx6vbGp6nXKx2TwPkLPf5NPw@mail.gmail.com>
[not found] ` <<fabfb1fd-4da1-4e72-90c9-333532011a48@default>
[not found] ` <<83pnahctad.fsf@gnu.org>
2020-06-02 17:10 ` Drew Adams
2020-06-02 18:41 ` Pip Cet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kssm04d.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=40968@debbugs.gnu.org \
--cc=mattiase@acm.org \
--cc=pipcet@gmail.com \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).