* bug#45454: 27.1; Help for EIEIO constructors has two consecutive spaces
@ 2020-12-27 11:50 Tim Landscheidt
2020-12-27 23:39 ` Lars Ingebrigtsen
0 siblings, 1 reply; 6+ messages in thread
From: Tim Landscheidt @ 2020-12-27 11:50 UTC (permalink / raw)
To: 45454; +Cc: david engster
[-- Attachment #1: Type: text/plain, Size: 181 bytes --]
X-Debbugs-CC: David Engster <dengste@eml.cc>
Severity: minor
Tags: patch
For non-autoloaded EIEIO constructor functions,
eieio-help-constructor will output two consecutive spaces.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Do-not-output-two-spaces-for-non-autoloaded-object-c.patch --]
[-- Type: text/x-patch, Size: 1090 bytes --]
From 8f1b42ed9fb6a7f935c12a8caac6958d90c79eb6 Mon Sep 17 00:00:00 2001
From: Tim Landscheidt <tim@tim-landscheidt.de>
Date: Thu, 25 Jan 2018 02:55:44 +0000
Subject: [PATCH] ; Do not output two spaces for non-autoloaded object
constructor functions
* lisp/emacs-lisp/eieio-opt.el (eieio-help-constructor): Amend format
to avoid two spaces for non-autoloaded object constructor functions.
Copyright-paperwork-exempt: yes
---
lisp/emacs-lisp/eieio-opt.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lisp/emacs-lisp/eieio-opt.el b/lisp/emacs-lisp/eieio-opt.el
index 59af7e12d2..3b222b9312 100644
--- a/lisp/emacs-lisp/eieio-opt.el
+++ b/lisp/emacs-lisp/eieio-opt.el
@@ -136,9 +136,9 @@ eieio-help-constructor
(def (symbol-function ctr)))
(goto-char (point-min))
(prin1 ctr)
- (insert (format " is an %s object constructor function"
+ (insert (format " is an %sobject constructor function"
(if (autoloadp def)
- "autoloaded"
+ "autoloaded "
"")))
(when (and (autoloadp def)
(null location))
--
2.26.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#45454: 27.1; Help for EIEIO constructors has two consecutive spaces
2020-12-27 11:50 bug#45454: 27.1; Help for EIEIO constructors has two consecutive spaces Tim Landscheidt
@ 2020-12-27 23:39 ` Lars Ingebrigtsen
2020-12-29 16:11 ` Tim Landscheidt
0 siblings, 1 reply; 6+ messages in thread
From: Lars Ingebrigtsen @ 2020-12-27 23:39 UTC (permalink / raw)
To: Tim Landscheidt; +Cc: david engster, 45454
Tim Landscheidt <tim@tim-landscheidt.de> writes:
> * lisp/emacs-lisp/eieio-opt.el (eieio-help-constructor): Amend format
> to avoid two spaces for non-autoloaded object constructor functions.
>
> Copyright-paperwork-exempt: yes
Looks good to me; I've applied this to Emacs 28.
This is your fifth tiny change to Emacs, but looking over the other
changes, I think we're still below the limit.
But this means that you're cumulatively getting close to the maximum
before the FSF needs copyright assignment papers for your changes to
Emacs. Would you be willing to sign such papers now to expedite
applying any further patches from you in the future?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#45454: 27.1; Help for EIEIO constructors has two consecutive spaces
2020-12-27 23:39 ` Lars Ingebrigtsen
@ 2020-12-29 16:11 ` Tim Landscheidt
2020-12-30 2:53 ` Lars Ingebrigtsen
0 siblings, 1 reply; 6+ messages in thread
From: Tim Landscheidt @ 2020-12-29 16:11 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 45454
Lars Ingebrigtsen <larsi@gnus.org> wrote:
>> * lisp/emacs-lisp/eieio-opt.el (eieio-help-constructor): Amend format
>> to avoid two spaces for non-autoloaded object constructor functions.
>> Copyright-paperwork-exempt: yes
> Looks good to me; I've applied this to Emacs 28.
> This is your fifth tiny change to Emacs, but looking over the other
> changes, I think we're still below the limit.
> But this means that you're cumulatively getting close to the maximum
> before the FSF needs copyright assignment papers for your changes to
> Emacs. Would you be willing to sign such papers now to expedite
> applying any further patches from you in the future?
Yes; in 2018, I (IIRC unpromptedly) started the process
(gnu.org #1268668), but I think it got stuck.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#45454: 27.1; Help for EIEIO constructors has two consecutive spaces
2020-12-29 16:11 ` Tim Landscheidt
@ 2020-12-30 2:53 ` Lars Ingebrigtsen
2020-12-30 5:59 ` Tim Landscheidt
0 siblings, 1 reply; 6+ messages in thread
From: Lars Ingebrigtsen @ 2020-12-30 2:53 UTC (permalink / raw)
To: Tim Landscheidt; +Cc: 45454
Tim Landscheidt <tim@tim-landscheidt.de> writes:
> Yes; in 2018, I (IIRC unpromptedly) started the process
> (gnu.org #1268668), but I think it got stuck.
Hm. Did it get stuck on the FSF side or because of something else?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#45454: 27.1; Help for EIEIO constructors has two consecutive spaces
2020-12-30 2:53 ` Lars Ingebrigtsen
@ 2020-12-30 5:59 ` Tim Landscheidt
2020-12-31 3:35 ` Lars Ingebrigtsen
0 siblings, 1 reply; 6+ messages in thread
From: Tim Landscheidt @ 2020-12-30 5:59 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 45454
Lars Ingebrigtsen <larsi@gnus.org> wrote:
>> Yes; in 2018, I (IIRC unpromptedly) started the process
>> (gnu.org #1268668), but I think it got stuck.
> Hm. Did it get stuck on the FSF side or because of something else?
I don't know. The last mail I got was an acknowledgement
from Theodore Teah on February 20, 2018 saying (with regard
to the scan of my signed assignment form which initially was
too large to send by mail): "I downloaded without problem
and it's crystal. What can I say we all have our limits and
some might be a bit too low :) Thank you. I'll get it back
to you shortly."
But I'm happy to sign the form again.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#45454: 27.1; Help for EIEIO constructors has two consecutive spaces
2020-12-30 5:59 ` Tim Landscheidt
@ 2020-12-31 3:35 ` Lars Ingebrigtsen
0 siblings, 0 replies; 6+ messages in thread
From: Lars Ingebrigtsen @ 2020-12-31 3:35 UTC (permalink / raw)
To: Tim Landscheidt; +Cc: 45454
Tim Landscheidt <tim@tim-landscheidt.de> writes:
> I don't know. The last mail I got was an acknowledgement
> from Theodore Teah on February 20, 2018 saying (with regard
> to the scan of my signed assignment form which initially was
> too large to send by mail): "I downloaded without problem
> and it's crystal. What can I say we all have our limits and
> some might be a bit too low :) Thank you. I'll get it back
> to you shortly."
Oops. I'll ping the copyright clerk and see what's up.
> But I'm happy to sign the form again.
Hopefully that won't be necessary.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-12-31 3:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-27 11:50 bug#45454: 27.1; Help for EIEIO constructors has two consecutive spaces Tim Landscheidt
2020-12-27 23:39 ` Lars Ingebrigtsen
2020-12-29 16:11 ` Tim Landscheidt
2020-12-30 2:53 ` Lars Ingebrigtsen
2020-12-30 5:59 ` Tim Landscheidt
2020-12-31 3:35 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).