From: Lars Ingebrigtsen <larsi@gnus.org>
To: Matt Armstrong <matt@rfc20.org>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, 46819@debbugs.gnu.org
Subject: bug#46819: 28.0.50; Undesireable warning: Empty let body from the `benchmark-run' implementation
Date: Mon, 01 Mar 2021 01:09:03 +0100 [thread overview]
Message-ID: <874khvd9b4.fsf@gnus.org> (raw)
In-Reply-To: <m2eegzn3hh.fsf@matts-mbp-2016.lan> (Matt Armstrong's message of "Sun, 28 Feb 2021 16:04:42 -0800")
Matt Armstrong <matt@rfc20.org> writes:
> It might be hard to fix in the general case. Think about this example:
>
> (let (...)
> (some-macro blah))
>
> What if that macro expands to nothing, based on some criteria not
> entirely under programmer control? Is the code "wrong"?
No. But if the code is
(let (...)
)
then it probably is. So the warning (if retained) has to be done on the
form read before doing any macro expansions.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-03-01 0:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-27 20:18 bug#46819: 28.0.50; Undesireable warning: Empty let body from the `benchmark-run' implementation Matt Armstrong
2021-02-27 21:00 ` Stefan Monnier
2021-02-28 14:13 ` Lars Ingebrigtsen
2021-03-01 0:04 ` Matt Armstrong
2021-03-01 0:09 ` Lars Ingebrigtsen [this message]
2021-03-01 0:19 ` Lars Ingebrigtsen
2021-03-01 5:04 ` Stefan Monnier
2021-03-02 5:07 ` Matt Armstrong
2021-03-10 4:53 ` Matt Armstrong
2021-03-10 14:54 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874khvd9b4.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=46819@debbugs.gnu.org \
--cc=matt@rfc20.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).