From: Matt Armstrong <matt@rfc20.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, 46819@debbugs.gnu.org
Subject: bug#46819: 28.0.50; Undesireable warning: Empty let body from the `benchmark-run' implementation
Date: Tue, 09 Mar 2021 20:53:19 -0800 [thread overview]
Message-ID: <874khj8v9c.fsf@rfc20.org> (raw)
In-Reply-To: <87h7lwmgaj.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 28 Feb 2021 15:13:24 +0100")
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>> It'd be easy to put an explicit nil in the loop's body, but....
>>
>> The idea was that in actual (non-macroexpanded) source code, empty let
>> bodies are usually the result of a misplaced paren. But it's probably
>> more often annoying than useful since we can't easily distinguish a "let
>> from source code" from a "let from a macro expansion".
>>
>> So I'm also voting to revert that change.
>> Any objection?
>
> It is a nice and helpful warning, though, so if it could be fixed in
> another way, that'd be great. (But I have no idea how, of course.)
So, after a little flurry of a conversation, this went quiet.
How about we fix benchmark's use of `let', and leave the warning in
place. It does not seem to be generating many other complaints, so it
may not be particularly annoying after all. I'm currently working with
`benchmark-run' a bunch and would like the warning gone from that one
use.
I can make a patch, but a one liner might be quicker for one of you to
just commit directly. ;-)
next prev parent reply other threads:[~2021-03-10 4:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-27 20:18 bug#46819: 28.0.50; Undesireable warning: Empty let body from the `benchmark-run' implementation Matt Armstrong
2021-02-27 21:00 ` Stefan Monnier
2021-02-28 14:13 ` Lars Ingebrigtsen
2021-03-01 0:04 ` Matt Armstrong
2021-03-01 0:09 ` Lars Ingebrigtsen
2021-03-01 0:19 ` Lars Ingebrigtsen
2021-03-01 5:04 ` Stefan Monnier
2021-03-02 5:07 ` Matt Armstrong
2021-03-10 4:53 ` Matt Armstrong [this message]
2021-03-10 14:54 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874khj8v9c.fsf@rfc20.org \
--to=matt@rfc20.org \
--cc=46819@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).