unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Gong Qijian <gongqijian@gmail.com>
Cc: 48492@debbugs.gnu.org
Subject: bug#48492: [PATCH] Fix wrong-type-argument error while loading pdump file
Date: Tue, 18 May 2021 16:37:52 +0200	[thread overview]
Message-ID: <874kf0f6pr.fsf@gnus.org> (raw)
In-Reply-To: <20210517123158.81940-1-gongqijian@gmail.com> (Gong Qijian's message of "Mon, 17 May 2021 20:31:58 +0800")

Gong Qijian <gongqijian@gmail.com> writes:

> This issue was introduced by commit 2fb271ca "Fix unload+reload of
> files using `custom-initialize-delay` (bug#47072)" which changed the
> initial value of `custom-delayed-init-variables` from nil to t.

[...]

> -  (setq custom-delayed-init-variables
> -        ;; Initialize them in the same order they were loaded, in case there
> -        ;; are dependencies between them.
> -        (nreverse custom-delayed-init-variables))
> -  (mapc #'custom-reevaluate-setting custom-delayed-init-variables)
> -  (setq custom-delayed-init-variables t)
> +  (when (listp custom-delayed-init-variables)
> +    (setq custom-delayed-init-variables
> +          ;; Initialize them in the same order they were loaded, in case there
> +          ;; are dependencies between them.
> +          (nreverse custom-delayed-init-variables))
> +    (mapc #'custom-reevaluate-setting custom-delayed-init-variables)
> +    (setq custom-delayed-init-variables t))

Thanks -- I've applied this with a change: The pre-patched version would
set `custom-delayed-init-variables' to t always, but with this patch,
it's only set if `custom-delayed-init-variables' is a proper list.  So I
moved the last setq out of the `when'.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





      reply	other threads:[~2021-05-18 14:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-17 12:31 bug#48492: [PATCH] Fix wrong-type-argument error while loading pdump file Gong Qijian
2021-05-18 14:37 ` Lars Ingebrigtsen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874kf0f6pr.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=48492@debbugs.gnu.org \
    --cc=gongqijian@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).