unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Gong Qijian <gongqijian@gmail.com>
To: 48492@debbugs.gnu.org
Cc: Gong Qijian <gongqijian@gmail.com>
Subject: bug#48492: [PATCH] Fix wrong-type-argument error while loading pdump file
Date: Mon, 17 May 2021 20:31:58 +0800	[thread overview]
Message-ID: <20210517123158.81940-1-gongqijian@gmail.com> (raw)

* lisp/startup.el(command-line): Don't reverse the
`custom-delayed-init-variables` if it's a non-list.

This issue was introduced by commit 2fb271ca "Fix unload+reload of
files using `custom-initialize-delay` (bug#47072)" which changed the
initial value of `custom-delayed-init-variables` from nil to t.

Steps to reproduce:

⋊> ./src/emacs --batch --eval '(dump-emacs-portable "dump")' && \
   ./src/emacs --dump-file=dump -nw -Q --batch
Debugger entered--Lisp error: (wrong-type-argument arrayp t)
  command-line()
  normal-top-level()
---
 lisp/startup.el | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/lisp/startup.el b/lisp/startup.el
index bb25c1b7..0df4fe02 100644
--- a/lisp/startup.el
+++ b/lisp/startup.el
@@ -1197,12 +1197,13 @@ command-line
 
   ;; Re-evaluate predefined variables whose initial value depends on
   ;; the runtime context.
-  (setq custom-delayed-init-variables
-        ;; Initialize them in the same order they were loaded, in case there
-        ;; are dependencies between them.
-        (nreverse custom-delayed-init-variables))
-  (mapc #'custom-reevaluate-setting custom-delayed-init-variables)
-  (setq custom-delayed-init-variables t)
+  (when (listp custom-delayed-init-variables)
+    (setq custom-delayed-init-variables
+          ;; Initialize them in the same order they were loaded, in case there
+          ;; are dependencies between them.
+          (nreverse custom-delayed-init-variables))
+    (mapc #'custom-reevaluate-setting custom-delayed-init-variables)
+    (setq custom-delayed-init-variables t))
 
   ;; Warn for invalid user name.
   (when init-file-user
-- 
2.25.0






             reply	other threads:[~2021-05-17 12:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-17 12:31 Gong Qijian [this message]
2021-05-18 14:37 ` bug#48492: [PATCH] Fix wrong-type-argument error while loading pdump file Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210517123158.81940-1-gongqijian@gmail.com \
    --to=gongqijian@gmail.com \
    --cc=48492@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).