From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: robin.neatherway@gmail.com, Dmitry Gutov <dgutov@yandex.ru>,
20846@debbugs.gnu.org
Subject: bug#20846: 24.4; Electric-indent-mode does not call indent-line-function after hitting RET inside a comment
Date: Sun, 30 May 2021 06:14:18 +0200 [thread overview]
Message-ID: <874kek7t9h.fsf@gnus.org> (raw)
In-Reply-To: <jwv8s3xfzya.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sat, 29 May 2021 09:24:01 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> The logic here is that the functions on the hook can return either nil
> to mean "indent, of course" or `no-indent` or `do-indent` where this
> last one overrides the default "don't indent inside a string or comment"
> (and it also overrides potential other functions on that hook which
> might have said `no-indent`).
Right. By the way, `electric-indent-functions' talks about the
`no-indent' symbol, while `indent-line-function' talks about the
`noindent' symbol... but skimming the code, I guess they're used in
different contexts, so that's not actually an issue.
>> so could you do the necessary here? :-)
>
> Done. Can we close this bug?
Yup; done now.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2021-05-30 4:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 15:40 bug#20846: 24.4; Electric-indent-mode does not call indent-line-function after hitting RET inside a comment Robin Neatherway
2015-06-18 15:50 ` bug#20846: Reproduction instruction correction Robin Neatherway
2021-05-26 23:32 ` bug#20846: 24.4; Electric-indent-mode does not call indent-line-function after hitting RET inside a comment Lars Ingebrigtsen
2021-05-27 7:00 ` Eli Zaretskii
2021-05-27 23:43 ` Lars Ingebrigtsen
2021-05-28 5:49 ` Eli Zaretskii
2021-05-28 12:56 ` Dmitry Gutov
2021-05-28 13:06 ` Eli Zaretskii
2021-05-28 13:35 ` Dmitry Gutov
2021-05-28 14:04 ` Eli Zaretskii
2021-05-28 14:09 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-28 14:16 ` Eli Zaretskii
2021-05-29 2:26 ` Lars Ingebrigtsen
2021-05-29 13:24 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-30 4:14 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kek7t9h.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=20846@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=monnier@iro.umontreal.ca \
--cc=robin.neatherway@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).