From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#20846: 24.4; Electric-indent-mode does not call indent-line-function after hitting RET inside a comment Date: Sun, 30 May 2021 06:14:18 +0200 Message-ID: <874kek7t9h.fsf@gnus.org> References: <871r9t6pgd.fsf@gnus.org> <838s40acf9.fsf@gnu.org> <87sg273fqo.fsf@gnus.org> <83fsy78l2p.fsf@gnu.org> <49c82e08-f15e-e564-1740-86271fc94f3b@yandex.ru> <8335u780u6.fsf@gnu.org> <874kemwa0a.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27825"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: robin.neatherway@gmail.com, Dmitry Gutov , 20846@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 30 06:15:27 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lnCrH-00073q-7s for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 May 2021 06:15:27 +0200 Original-Received: from localhost ([::1]:36702 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lnCrG-0003nv-2f for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 May 2021 00:15:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43364) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lnCqs-0003n4-62 for bug-gnu-emacs@gnu.org; Sun, 30 May 2021 00:15:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46506) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lnCqr-0002FJ-PE for bug-gnu-emacs@gnu.org; Sun, 30 May 2021 00:15:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lnCqr-0007Vu-LA for bug-gnu-emacs@gnu.org; Sun, 30 May 2021 00:15:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 May 2021 04:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20846 X-GNU-PR-Package: emacs Original-Received: via spool by 20846-submit@debbugs.gnu.org id=B20846.162234807128816 (code B ref 20846); Sun, 30 May 2021 04:15:01 +0000 Original-Received: (at 20846) by debbugs.gnu.org; 30 May 2021 04:14:31 +0000 Original-Received: from localhost ([127.0.0.1]:58049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnCqN-0007Ui-E6 for submit@debbugs.gnu.org; Sun, 30 May 2021 00:14:31 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:44434) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnCqL-0007UT-2Z for 20846@debbugs.gnu.org; Sun, 30 May 2021 00:14:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=s81sirdeMEvptZbjdX6iw6IQBjxPvbrEFZPDHa1CSWQ=; b=WauDDFaI8+0tNTDP3jVbybuBxj lm+0SdBWeq+Zo9LH+e1rWbVDopyopb9JJ2ErKXJk8t6bvO21CJVoBsaeynRg+lzSAbuGJTAnWUg+Y eQdBCcZHdH14/JmsCilGjEyEYzGKZK5qYic6on78TM17loMf9ycP1PpYgvtNlEVSS37Y=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lnCqB-0005bZ-Ha; Sun, 30 May 2021 06:14:21 +0200 X-Now-Playing: Crosby, Stills, Nash & Young's =?UTF-8?Q?=5FD=C3=A9j=C3=A0?= Vu_: "Woodstock" In-Reply-To: (Stefan Monnier's message of "Sat, 29 May 2021 09:24:01 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207567 Archived-At: Stefan Monnier writes: > The logic here is that the functions on the hook can return either nil > to mean "indent, of course" or `no-indent` or `do-indent` where this > last one overrides the default "don't indent inside a string or comment" > (and it also overrides potential other functions on that hook which > might have said `no-indent`). Right. By the way, `electric-indent-functions' talks about the `no-indent' symbol, while `indent-line-function' talks about the `noindent' symbol... but skimming the code, I guess they're used in different contexts, so that's not actually an issue. >> so could you do the necessary here? :-) > > Done. Can we close this bug? Yup; done now. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no