From: Lars Ingebrigtsen <larsi@gnus.org>
To: Alex Bochannek <alex@bochannek.com>
Cc: 48801@debbugs.gnu.org
Subject: bug#48801: 28.0.50; [PATCH] Feature suggestion gnus-retrieve-headers check for nov-is-evil when agent is enabled
Date: Fri, 04 Jun 2021 11:35:46 +0200 [thread overview]
Message-ID: <874kee0y6l.fsf@gnus.org> (raw)
In-Reply-To: <m21r9izv1u.fsf@bochannek.com> (Alex Bochannek's message of "Thu, 03 Jun 2021 11:01:49 -0700")
Alex Bochannek <alex@bochannek.com> writes:
> Is there any documentation you would like to see before accepting this
> change?
I don't think the patch is the right thing to do:
diff --git a/lisp/gnus/gnus-int.el b/lisp/gnus/gnus-int.el
index 01053797b3..d2d7fd55ae 100644
--- a/lisp/gnus/gnus-int.el
+++ b/lisp/gnus/gnus-int.el
@@ -527,7 +527,11 @@ gnus-retrieve-headers
((and gnus-use-cache (numberp (car articles)))
(gnus-cache-retrieve-headers articles group fetch-old))
((and gnus-agent (gnus-online gnus-command-method)
- (gnus-agent-method-p gnus-command-method))
+ (gnus-agent-method-p gnus-command-method)
+ (not gnus-nov-is-evil)
So you're basically disabling the Agent when gnus-nov-is-evil is set,
and while it solves this problem, it's not a good general solution --
the two things are kinda-sort orthogonal. Instead you should just
exclude the nnvirtual component groups from the Agent.
+ (not (symbol-value
+ (intern
+ (format "%s-nov-is-evil" (car gnus-command-method))))))
(And this isn't correct anyway -- not all backends have a -nov-is-evil
variable).
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-06-04 9:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 21:13 bug#48801: 28.0.50; [PATCH] Feature suggestion gnus-retrieve-headers check for nov-is-evil when agent is enabled Alex Bochannek
2021-06-03 7:59 ` Lars Ingebrigtsen
2021-06-03 18:01 ` Alex Bochannek
2021-06-04 9:35 ` Lars Ingebrigtsen [this message]
2021-06-04 17:40 ` Alex Bochannek
2021-06-06 9:36 ` Lars Ingebrigtsen
2021-06-06 17:51 ` Alex Bochannek
2021-06-08 9:57 ` Lars Ingebrigtsen
2021-06-08 15:50 ` Alex Bochannek
2021-06-09 5:35 ` Alex Bochannek
2021-06-09 9:59 ` Lars Ingebrigtsen
2021-06-09 18:05 ` Alex Bochannek
2021-06-09 18:14 ` Eli Zaretskii
2021-06-09 18:47 ` Alex Bochannek
2021-06-09 18:55 ` Eli Zaretskii
2021-06-09 19:04 ` Alex Bochannek
2021-06-12 12:10 ` Lars Ingebrigtsen
2021-06-12 17:49 ` Alex Bochannek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kee0y6l.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=48801@debbugs.gnu.org \
--cc=alex@bochannek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).