From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#48801: 28.0.50; [PATCH] Feature suggestion gnus-retrieve-headers check for nov-is-evil when agent is enabled Date: Fri, 04 Jun 2021 11:35:46 +0200 Message-ID: <874kee0y6l.fsf@gnus.org> References: <87im2v9y4u.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18497"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 48801@debbugs.gnu.org To: Alex Bochannek Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 04 11:37:08 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lp6GK-0004hn-MU for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Jun 2021 11:37:08 +0200 Original-Received: from localhost ([::1]:35464 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lp6GJ-0002We-Oz for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Jun 2021 05:37:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44374) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lp6GE-0002WO-EC for bug-gnu-emacs@gnu.org; Fri, 04 Jun 2021 05:37:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33840) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lp6GE-0007Os-6d for bug-gnu-emacs@gnu.org; Fri, 04 Jun 2021 05:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lp6GE-0001Ty-3u for bug-gnu-emacs@gnu.org; Fri, 04 Jun 2021 05:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Jun 2021 09:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48801 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 48801-submit@debbugs.gnu.org id=B48801.16227993625608 (code B ref 48801); Fri, 04 Jun 2021 09:37:02 +0000 Original-Received: (at 48801) by debbugs.gnu.org; 4 Jun 2021 09:36:02 +0000 Original-Received: from localhost ([127.0.0.1]:45386 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lp6FG-0001SO-JR for submit@debbugs.gnu.org; Fri, 04 Jun 2021 05:36:02 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:59242) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lp6FC-0001Rl-No for 48801@debbugs.gnu.org; Fri, 04 Jun 2021 05:36:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=HHmdwA9/CTmya0JNWD0eamUb1lqhgBVbawL9LD33GVo=; b=qFz+qOLqXKTMGHZEJa8j34Zd2L TTwARpsVKL+cOO5dzPA4R8O13gBnCxCb7MG0VJnPgpfg79dx3xJaFb4j2f6IITzx2E8a9obrYDnAQ LJXnD2AiS/wBzZrcG8LAhgY5hiZDV8T3i6SRGlcZV7kGUGK2CE80D5ftxgoyVZdV/49s=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lp6F1-0003po-C5; Fri, 04 Jun 2021 11:35:51 +0200 X-Now-Playing: Cosey Fanni Tutti's _Make More Noise (3)_: "Such Is Life (featuring John Lacey)" In-Reply-To: (Alex Bochannek's message of "Thu, 03 Jun 2021 11:01:49 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207991 Archived-At: Alex Bochannek writes: > Is there any documentation you would like to see before accepting this > change? I don't think the patch is the right thing to do: diff --git a/lisp/gnus/gnus-int.el b/lisp/gnus/gnus-int.el index 01053797b3..d2d7fd55ae 100644 --- a/lisp/gnus/gnus-int.el +++ b/lisp/gnus/gnus-int.el @@ -527,7 +527,11 @@ gnus-retrieve-headers ((and gnus-use-cache (numberp (car articles))) (gnus-cache-retrieve-headers articles group fetch-old)) ((and gnus-agent (gnus-online gnus-command-method) - (gnus-agent-method-p gnus-command-method)) + (gnus-agent-method-p gnus-command-method) + (not gnus-nov-is-evil) So you're basically disabling the Agent when gnus-nov-is-evil is set, and while it solves this problem, it's not a good general solution -- the two things are kinda-sort orthogonal. Instead you should just exclude the nnvirtual component groups from the Agent. + (not (symbol-value + (intern + (format "%s-nov-is-evil" (car gnus-command-method)))))) (And this isn't correct anyway -- not all backends have a -nov-is-evil variable). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no