From: Lars Ingebrigtsen <larsi@gnus.org>
To: <miha@kamnitnik.top>
Cc: 51974@debbugs.gnu.org
Subject: bug#51974: 29.0.50; [PATCH] Fix deactivation of outline-minor-mode-cycle-map bindings
Date: Sun, 21 Nov 2021 09:12:50 +0100 [thread overview]
Message-ID: <874k86orjx.fsf@gnus.org> (raw)
In-Reply-To: <87ilwnds17.fsf@miha-pc> (miha@kamnitnik.top's message of "Sat, 20 Nov 2021 11:45:40 +0100")
<miha@kamnitnik.top> writes:
> This has a small disadvantage: deactivating outline-minor-mode will
> remove all 'keymap' text properties from the whole buffer, even if they
> are added by other minor or major modes or whatever.
Yes, that's not good, either. Alternatively, it could remove all the
`keymap' entries where the keymap is the outline keymap. (This would
break if the keymap is redefined, but...)
> With 'char-property-alias-alist', we can create a sort of namespacing
> to ensure that outline-minor-mode messes only with its own text
> properties.
Yup. Hm. Well, perhaps it is the best solution here. It's just pretty
unusual to use char-property-alias-alist for something like this. I
guess other minor modes use overlays, which makes it easier to identify
what things belong to the minor mode? (Text properties have a vaguer
identity.)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-11-21 8:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 11:41 bug#51974: 29.0.50; [PATCH] Fix deactivation of outline-minor-mode-cycle-map bindings miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-20 9:45 ` Lars Ingebrigtsen
2021-11-20 10:45 ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-21 8:12 ` Lars Ingebrigtsen [this message]
2021-11-21 17:55 ` Juri Linkov
2021-11-21 17:58 ` Juri Linkov
2022-01-11 19:24 ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874k86orjx.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=51974@debbugs.gnu.org \
--cc=miha@kamnitnik.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).