From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#51974: 29.0.50; [PATCH] Fix deactivation of outline-minor-mode-cycle-map bindings Date: Sun, 21 Nov 2021 09:12:50 +0100 Message-ID: <874k86orjx.fsf@gnus.org> References: <87lf1ke5iy.fsf@miha-pc> <87h7c7qhxv.fsf@gnus.org> <87ilwnds17.fsf@miha-pc> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19438"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 51974@debbugs.gnu.org To: Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 21 09:14:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mohzE-0004ow-SP for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Nov 2021 09:14:08 +0100 Original-Received: from localhost ([::1]:39360 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mohzD-0007mx-II for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Nov 2021 03:14:07 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33248) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mohz8-0007mn-6L for bug-gnu-emacs@gnu.org; Sun, 21 Nov 2021 03:14:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60774) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mohz7-0004on-PM for bug-gnu-emacs@gnu.org; Sun, 21 Nov 2021 03:14:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mohz7-00035e-JO for bug-gnu-emacs@gnu.org; Sun, 21 Nov 2021 03:14:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Nov 2021 08:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51974 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51974-submit@debbugs.gnu.org id=B51974.163748238411778 (code B ref 51974); Sun, 21 Nov 2021 08:14:01 +0000 Original-Received: (at 51974) by debbugs.gnu.org; 21 Nov 2021 08:13:04 +0000 Original-Received: from localhost ([127.0.0.1]:44087 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mohyB-00033u-RL for submit@debbugs.gnu.org; Sun, 21 Nov 2021 03:13:04 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:51274) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mohyA-00032x-KE for 51974@debbugs.gnu.org; Sun, 21 Nov 2021 03:13:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=criSDaQqkW5O/lDhcypy3ZfCVT3sNjUIR34wo/fR1Js=; b=XT9NOa76a6ALahL3GWOo/rOnzO 3vYrgnkPqIKXFYjGqfuzZ15xr8aQiASEKfO73wVFvxgpdMkOqbnQGqPH9FbJclddXk883equaGRm0 DPyxz8DtB1nCdxD09zEXbTJkchKe9OhbHmnTYtST/tgyFJ0GT5wpxkBucW57DqP+4u7s=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mohy1-0003eY-6s; Sun, 21 Nov 2021 09:12:56 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAFVBMVEX6+Pbr49vY0s/A ra7l2NLJtLP///+HTxUtAAAAAWJLR0QGYWa4fQAAAAd0SU1FB+ULFQgEN0iIh54AAAGsSURBVDjL bVNRcusgDIS0B2AZ+m/JcIDGz/+GKv+tk9z/KhVJnRdwNJ7xDIuk3UUy1hj9XsTIXF4C1llji0SB awEpwGnilcvSAiyezseveSW0ADLCOE3TJXelLGDTLBnoMqJIuWY4K7kFiFAqpe6+9gCKX/OyU6lF /CWWvPRA1lJXTjRInyHkr/yiiQM8R2d2AQREiYjBd0AsJTH50nuVM3xiRNXSCRRkCe8UXLg59CzQ GffuXrS/P9YuGKT5dp8weKp89gDxwHr6oPQoyhrOpsHaHijMxsZsXgb8Jde7H8PHkszhiS9mqv80 Tf9WnYx5MGb19ch+fVbgLfIAZoq3ZpVpOE0R7RSLEAUqJ52s1sXM6hY8ztNRGpUB92l+u57bFFcL 26ATMbcDT5ElR1X5GdtFyDl47fETh070X49+bbSHugeDxH7tbAdDMk/rXeKTf3Uz8ikdRZZmsuAJ SGcZiVfaue7UdGWcn7eKDzwejUfduUrywY4xfhtzGszfEvoNIT9GrXPBpmRrNPAVNwqb4M0BSrOD j/psCgf5b/06HlfWNzEhdi4edi7d4he2TUCigZwhOwAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMS0x MS0yMVQwODowNDo1NSswMDowMJpV6q4AAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjEtMTEtMjFUMDg6 MDQ6NTUrMDA6MDDrCFISAAAAAElFTkSuQmCC X-Now-Playing: Tarnation's _Gentle Creatures_: "Halfway to Madness" In-Reply-To: <87ilwnds17.fsf@miha-pc> (miha@kamnitnik.top's message of "Sat, 20 Nov 2021 11:45:40 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220535 Archived-At: writes: > This has a small disadvantage: deactivating outline-minor-mode will > remove all 'keymap' text properties from the whole buffer, even if they > are added by other minor or major modes or whatever. Yes, that's not good, either. Alternatively, it could remove all the `keymap' entries where the keymap is the outline keymap. (This would break if the keymap is redefined, but...) > With 'char-property-alias-alist', we can create a sort of namespacing > to ensure that outline-minor-mode messes only with its own text > properties. Yup. Hm. Well, perhaps it is the best solution here. It's just pretty unusual to use char-property-alias-alist for something like this. I guess other minor modes use overlays, which makes it easier to identify what things belong to the minor mode? (Text properties have a vaguer identity.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no